search

bit-hack / tack

Tack - The vector wrapper
0 stars 0 forks source link

Remove bitwise operations from tack::float4 #23

Closed kbenzie closed 7 years ago

kbenzie commented 7 years ago

I'm of the opinion that bitwise operations on floats are not very useful for general use, so I've removed support for those intrinsics.

kbenzie commented 7 years ago

@8BitPimp I think you said something along these lines but I'm not totally sure if you'll agree with this.

bit-hack commented 7 years ago

So some of these can be very useful, for instance the and/or to quickly test if multiple floats are positive or negative. There may be a case however to make this user bitcast to int4 and do the operations then...

kbenzie commented 7 years ago

Yeah converting to was what I was expecting would be the replacement. I'm happy to close this PR but I don't know what the tests for these member functions should look like and I'm not really willing to dig into the bit representation of floats.