Closed kbenzie closed 8 years ago
I removed the stringstream, forgot to do that before pushing.
@8BitPimp so I've added ASSERT_MSG
and EXPECT_MSG
which set message_
in printf
style. The implementation does use snprintf
so these will break on Windows with any version less than Visual Studio 2015.
One question, should the ASSERT
and EXPECT
macros have the printf
parameters and drop the _MSG
variants?
I don't think we should drop the non MSG variants, since I think you might have to insert a parameter in the varargs section (I'm a bit fuzzy on it, but i've seen behaviour like that (just msvc?)). I am also happy just supporting VS2015 and onwards. This change looks good to me :+1: