Add Sleep/Hibernate option to "shutdown after backup"?

bit-team / backintime

Back In Time - An easy-to-use backup tool for GNU Linux using rsync in the back

https://backintime.readthedocs.io

GNU General Public License v2.0

2k stars 196 forks source link

Add Sleep/Hibernate option to "shutdown after backup"? #1268

Open nickbailey opened 2 years ago

nickbailey commented 2 years ago

My workflow is generally to run BiT after a work session, and it would be great if I could chose the kind of shutdown which got executed automatically. I'm on KDE Plasma, and I see from

https://github.com/bit-team/backintime/blob/29e874f5080f7cf85c8297ea807cb8070a427c10/common/tools.py#L1541

that I could hard code the desired behaviour in the source really very easily, but it would be great if there was an option to sleep instead of shutdown in environments which support it.

speedy-10 commented 2 years ago

I'd would like to have the option "sleep" and "shutdown", because both is useful.

FanisBak commented 3 months ago

Hello. I would like to work on this issue. I am a first time contributor!

buhtz commented 3 months ago

Hello Fanis, thank you for this kind offer.

Welcome to the project. Please do not hesitate to ask questions. Your solution don't need to be perfect.

Do you have a solution in mind? I am not very deep into that issue here and don't have an idea.

Please introduce your self and tell us about your skills, wishes and plans. Also let us know how you found the issue and the project.
Read the existing contributors documentation.
You also may find it interesting to learn more about the team and our strategy outline.

FanisBak commented 3 months ago

I am a student at Athens University of Business and Economics (AUEB). My skills include the basic of programming, but I am eager to learn. I have an assignment for one of my subjects and it is to make our first contribution to an open source project. I searched for projects the welcome and accept first time contributors and I thought that it is a good start for me, seeing the label of (good first issue) on some issues and also seeing that your responses were friendly. I am not sure about how to resolve the issue ,wet, but I will work on it the following days. Hope I can also provide some help and value to the project.

buhtz commented 3 months ago

Thank you for your feedback. Are you also a user of Back In Time? It makes contributing harder if you don't know the application.

Do you know about unit tests?

Let me suggest some more issues:

1105 is an easy GUI related issue
1018 might not be so easy but has a high value because ofter solving it we can work on some other things that depend on that feature.
255 has an easy to understand task but implementation might be complex.
875 is a documentation issue. We are not the founders of BIT so we need to investigate its behavior in some cases. The Auto-removal feature is not fully understood. It's behavior need to be investigated and documented.
You could have a look at the EditUserCallback dialog class. Remove it and replace its behavior with the systems default editor.

You can review PR #1730

FanisBak commented 3 months ago

I did not knew about Back in Time before searching for OSS projects to contribute for my uni assignment. I know some things about unit test. I have run some unit tests on my personal projects.

I just created a pull request, I would be very happy if you gave me some feedback.

I maybe also take a look at the other issues you suggested.

bit-team / backintime

Add Sleep/Hibernate option to "shutdown after backup"? #1268

1105 is an easy GUI related issue

1018 might not be so easy but has a high value because ofter solving it we can work on some other things that depend on that feature.

255 has an easy to understand task but implementation might be complex.

875 is a documentation issue. We are not the founders of BIT so we need to investigate its behavior in some cases. The Auto-removal feature is not fully understood. It's behavior need to be investigated and documented.