bit-team / backintime

Back In Time - An easy-to-use backup tool for GNU/Linux using rsync in the back
https://backintime.readthedocs.io
GNU General Public License v2.0
2.09k stars 204 forks source link

test & refactor Config.olderThan() #1791

Closed buhtz closed 1 month ago

buhtz commented 4 months ago

Introduction

Welcome to the project. If you pick up this Issue because of the "HELP WANTED" please let us now and introduce your self, your skills and wishes if you are new to the project.

Skills to solve this Issue

The problem

This is about the method config.py::Config.olderThan().

Your next steps

  1. If this is your first contribution in this project please introduce your self and tell us about your skills, wishes and plans. Also let us know how you found the issue and the project.
  2. Read the existing contributors documentation.
  3. We can develop the next steps in the further discussion. Don't hesitate to ask.
  4. See next section Solution.

Solution

  1. First, write unit tests to cover the whole behavior of that method.
  2. Improve the doc strings based on the things you learned about that method.
  3. Move the method somewhere else. If there is no better idea, just move it to common/tools.py as a function.
  4. Refactor the code without changing its behavior.