Fix W0612 (unused-variable) {qt}

[sakshamdahake]

Fixed the occurrence of unused variables through multiple files within /qt

[buhtz]

Can you please try to Run backintime and test the relevant functionality.

[buhtz]

Hello Saksham,

you have not answered in the last two days, so I need to escalate that. We had some bad experience in the past with some contributors and PRs. To save the resources of the project I need to be a bit strict about that.

The PR you provided has a very low quality. In fact it destroys the functionality of BIT and does not add something good to it. If this is because of a lack of Python experience we can work on this together, no problem. But to my experience with former contributions it looks more like AI generated content.

Please respond and explain.

If you don't I will abuse your profile to Microsoft GitHub. In the past this often resulted in banning such profiles from the whole platform. I will also consider to abuse you at LinkedIn because I am assuming that the companies and work experience you mention there is not real. Those experience you show on that profile do not reflect in the PR you provide here.

Best, Christian

[sakshamdahake]

Hello Christian,

I apologize for the delay in my response; I had some personal matters that needed my attention. I want to clarify that my intent is never to harm the project but to contribute positively to it.

Your allegations regarding my experience are inappropriate and unfounded. My professional background and the experiences listed on my LinkedIn are genuine, and I am committed to delivering quality work.

Regarding the PR, I would appreciate it if you could specify exactly what you find to be of low quality. My changes focused on removing unused variables, which should not affect any other functionality. If there's something more specific that you're concerned about, I am more than willing to discuss and address it.

I will also run BackInTime and test the relevant functionality shortly, and I'll update you here with the results.

I am open to constructive feedback and ready to collaborate to ensure that the project meets the highest standards.

Thank you for your understanding.

Best regards, Saksham

[sakshamdahake]

Hi, I am trying to create .deb package file as mentioned here: https://github.com/sakshamdahake/backintime/blob/pylint-rules/CONTRIBUTING.md#build-own-deb-file

But looks like the makedeb.sh script is not present in root dir of BIT. Can you please guide me through building this package.

[buhtz]

Hi, I am trying to create .deb package file as mentioned here: https://github.com/sakshamdahake/backintime/blob/pylint-rules/CONTRIBUTING.md#build-own-deb-file

This section is in there on accident and is out-dated. You can also remove it and integrate that into this PR if you want. Please use the make file system to build and install as described here. Please also read this recommendations about how to contribute to our project.

[sakshamdahake]

I have installed using make file system but that doesn't work. Previously, I tried the latest development build, it got installed on my system successfully but when I try to open BIT GUI, it loads for a while and does not open! Can you please help me troubleshoot this issue?

[buhtz]

Can you please help me troubleshoot this issue?

But you help me first, so I can help you. You need to provide me with more details. How do you start BIT? What is the error message?

What do you read in the terminal? Try to start BIT in a shell with backintime-qt and let's see the output.

[sakshamdahake]

I get this in terminal:

Traceback (most recent call last): File "/usr/share/backintime/qt/app.py", line 40, in import qttools File "/usr/share/backintime/qt/qttools.py", line 35, in from PyQt6.QtGui import (QAction, QFont, QPalette, QIcon) ModuleNotFoundError: No module named 'PyQt6'

Even when pyqt-6 s already installed. I tried reinstalling the same but that didn't work.

[buhtz]

How do you install pyqt6? How do you verified that it is installed?

[sakshamdahake]

I was installing it with pip; Installed it with apt and now it works but now I have another error at hand:

Back In Time
Version: 1.4.3

Back In Time comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to redistribute it
under certain conditions; type `backintime --license' for details.

Traceback (most recent call last):
  File "/usr/share/backintime/qt/app.py", line 2073, in <module>
    translator = qttools.initiate_translator(cfg.language())
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/backintime/qt/qttools.py", line 372, in initiate_translator
    tools.set_lc_time_by_language_code(language_code)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'tools' has no attribute 'set_lc_time_by_language_code'

[buhtz]

Look at the version number in the output. 1.4.3 is not the development version. Read the contributing.md Document please.

EDIT: Ok, now I am awake. Again please read carefully the CONTRIBUTING.md. Install all dependencies as described. Then install BIT from your own git branch "pylint-rules". Make sure you don't accidentally run another instance of BIT that was previously installed (e.g. from your GNU/Linux distro package repository via apt-get or pacman).

[sakshamdahake]

You are right! That's the stable version. Maybe I need to remove the stable installation and install dev version again?

Edit- I got it running on my local. I have tested my changes and something is breaking BIT. Working on it...

[buhtz]

David, just FYI. The unit test won't fail because the "qt" component of Back In Time does not have regular unit tests. There is only one "test" running pylint.

[buhtz]

I have to close the PR if I see no further progress.