bit101 / quicksettings

JavaScript library for making a quick settings panel to control code parameters.
MIT License
458 stars 52 forks source link

Now setColor will set background color of label. #9

Closed DonKarlssonSan closed 8 years ago

DonKarlssonSan commented 8 years ago

When calling setColor(), the background color of the label is not updated.

  1. Add a color picker
  2. Call setColor from your code -> now the color number on qs_label, will update but not the background color of qs_color_label.

Repro on CodePen: http://codepen.io/DonKarlssonSan/pen/ALqpQZ

I'm not sure whether this is the most elegant fix but it seems to work. =)

bit101 commented 8 years ago

Thanks! I just fixed that in the "next" branch, which will be merged to master shortly.

domisolsi commented 7 years ago

Can't get quicksetting.js fixed in the master repository(?) setColor() doesn't update the label yet... Thanks for your reply