search

bit3725 / postcss-shopify-settings-variables

PostCSS plugin for variable of theme setting in shopify css file.
MIT License
14 stars 6 forks source link

Multiple settings on same line only converts first instance #8

Open cshold opened 4 years ago

cshold commented 4 years ago

Writing this:

font-family: $(type_header_font_family.family), $(type_header_font_family.fallback_families);

I would expect:

font-family: {{ settings.type_header_font_family.family }}, {{ settings.type_header_font_family.fallback_families }};

But get this:

font-family: {{ settings.type_header_font_family.family }}, $(type_header_font_family.fallback_families);

Only the first $(variable) is parsed.

coppinger commented 4 years ago

Any updates on this cshold? Doesn't seem like a deal-breaker considering the utility this plugin would bring, but it would be great to have it working as intended.

cshold commented 4 years ago

Nope

coppinger commented 4 years ago

Nope

Did you end up using this at all? I'm keen to use it on a project starting this week, as I'd like to utilise Tailwind CSS and it requires PostCSS. The inability to set variables to schema values would be a deal-breaker.

cshold commented 4 years ago

Yes, but organized my variables differently. For most Shopify variables I started using CSS variables in :root in theme.liquid. Takes the need out of this plugin mostly so I'll likely move away from it soon.

coppinger commented 4 years ago

Gotcha, thanks for letting me know - I think I'll probably go down that path too.

I've been meaning to have a catchup with some other Shopify theme dev's such as yourself for some time, as I'd love to share workflows and insights. If you might be interested in a short Zoom call at some point, drop me a message or email me at charles.coppinger@gmail.com

Cheers!

coppinger commented 4 years ago

Apologies Carson, I've just done my homework and realised you're a bit of a legend when it comes to Shopify theme development - my invite for some knowledge sharing still stands, but I completely understand if you're too busy/that's not something you're interested in doing.

Safe to say, the flow of knowledge would likely be in one direction!

cshold commented 4 years ago

Hah, you humble me. I'd say check out the ecommTalk Slack. Lots of good people in there with plenty of knowledge.

bit3725 commented 4 years ago

Hey guys, I just pushed a update to solve this issue. Could you please help to test if version 0.4.0 solves your problems if you still need this plugin?