bitDecayGames / Jump

Tile-based platformer engine aimed at early 90's era platformer capabilities.
MIT License
0 stars 3 forks source link

Convert jump to using resources from jar for UI #223

Open Kenoshen opened 8 years ago

Kenoshen commented 8 years ago

There is a call to LevelEditor.setAssetsDirectory that jumped out at me. It is set to the assets directory in the local version of jump on my machine. I'm guessing the reason for that is because jump currently has no way to access it's UI images or font files when it is run in a directory outside of the jump project directory.

This will become a problem once jump is installed via the maven repository since you wont have access to the source code.

The right way to handle this would be to bake the assets into the level editor jar and then reference the assets within the jar. That way you are completely independent of the source when it is all packaged up.

MondayHopscotch commented 8 years ago

I may have to work with you on getting this to work. But I understand why it needs to be done - so I'll make it happen.

On Thu, Oct 6, 2016, 09:13 Michael Wingfield notifications@github.com wrote:

There is a call to LevelEditor.setAssetsDirectory that jumped out at me. It is set to the assets directory in the local version of jump on my machine. I'm guessing the reason for that is because jump currently has no way to access it's UI images or font files when it is run in a directory outside of the jump project directory.

This will become a problem once jump is installed via the maven repository since you wont have access to the source code.

The right way to handle this would be to bake the assets into the level editor jar and then reference the assets within the jar. That way you are completely independent of the source when it is all packaged up.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitDecayGames/Jump/issues/223, or mute the thread https://github.com/notifications/unsubscribe-auth/ADSL0d1bgL4jI5OItuy5ZlkGAa__q9gPks5qxRAKgaJpZM4KQD9m .