search

bitExpert / magento2-force-login

Force Customer Login Module for Magento 2
https://marketplace.magento.com/bitexpert-magento2-force-customer-login.html
Apache License 2.0
166 stars 73 forks source link

Remove useless wrong error #231

Closed iranimij closed 6 months ago

iranimij commented 6 months ago

https://github.com/bitExpert/magento2-force-login/issues/230

shochdoerfer commented 6 months ago

Thank you for spotting this and providing a fix!

@rikwillems WDTY?

rikwillems commented 6 months ago

@iranimij @shochdoerfer this looks like a good solution for these previously existing items.

Checks are running now and I will merge it in when they succeed.

coveralls commented 6 months ago

Coverage Status

coverage: 58.745% (-0.1%) from 58.857% when pulling 9b451aab5b27e89949c62f87820ac2a8eac2f7ad on iranimij:remove-useless-wrong-error into 760bbd333d319218e909b6e483647a9170e64d08 on bitExpert:master.

shochdoerfer commented 6 months ago

@rikwillems if you need me to craft a release, let me know. Happy to help :)

rikwillems commented 6 months ago

@shochdoerfer the issues in CI are unrelated to the PR. Shall we combine this with #233 and #234 and create a release?

shochdoerfer commented 6 months ago

@rikwillems sounds like a plan. Should I create the release or do you want to take over?