search

bitExpert / phpstan-magento

Magento specific extension for PHPStan
MIT License
134 stars 24 forks source link

Integration tests needed for CI pipeline #244

Closed shochdoerfer closed 1 year ago

shochdoerfer commented 2 years ago

The problem in #243 shows that we need integration tests to detect real-world problems with newer PHPStan releases. Since we have some dependencies deeper in PHPStan's core, things can break.

Ideally, we'd have a demo Magento module that covers all the different features the extension offers. This would also simplify my testing as currently, I am running the dev versions against multiple modules.

shochdoerfer commented 2 years ago

Repo: https://github.com/bitExpert/phpstan-magento-int

shochdoerfer commented 2 years ago

The repo already contains a Magento platform setup as well as GitHub Actions: One to install Magento and run PHPStan against Magento platform and one to run PHPStan against a stand-alone module.

Next up: Add a sample module with all the features covered by this extension.

shochdoerfer commented 2 years ago

The integration repo is improving: The repo will run a nightly build against a demo module as part of a Magento platform project as well as a stand-alone module.

The first "testcases" have been added and the CI Pipeline got fine-tuned.