bitExpert / prophiler-psr7-middleware

[DEPRECATED] Prophiler PSR7 Middleware
Apache License 2.0
7 stars 8 forks source link

Problems with dependency to fabfuel/prophiler #11

Closed Musiksammler closed 8 years ago

Musiksammler commented 8 years ago

Fabfuel's prophiler has a strict dependency to PHP 5.x so it's not possible to install it under PHP7.

He offers the branch "dev-feature/php7" to do so and that's works if installed alone.

Your middleware has a dependecy for prophiler version 1.4/1.5. When I defined "dev-feature/php7" for prophiler in my composer.json prophiler-psr7-middleware fails with the message

bitexpert/prophiler-psr7-middleware dev-master requires fabfuel/prophiler ^1.4 -> satisfiable by fabfuel/prophiler[1.4.0, 1.5.0] but these conflict with your requirements or minimum-stability.

Of course I can use the option "--ignore-platform-reqs" for the standard prophiler package but I would prefer a solution without that.

shochdoerfer commented 8 years ago

Good catch. I was hoping that PHP7 support would be merged much quicker in fabfuel/prophiler. I believe we can add a simple rule to the composer.json file to fix it. Just need to figure out a solution for the Travis build which will fail then (due to the locked dependencies in the composer.lock file).

shochdoerfer commented 8 years ago

@Musiksammler I just released version 0.3.0 to address this issue. You can now define the dependencies in your root composer.json like this to install the PHP 7 version of fabfuel/prophiler:

{
  "require": {
    "php": "^7.0",
    "fabfuel/prophiler": "dev-feature/php7",
    "bitexpert/prophiler-psr7-middleware": "^0.3.0"
  }  
}
Musiksammler commented 8 years ago

Works, thank you!