search

bitbank2 / PNGenc

An embedded-friendly PNG encoder
Apache License 2.0
39 stars 8 forks source link

Corruption with addLine but not addRGB565Line #16

Open prplz opened 10 months ago

prplz commented 10 months ago

I was experiencing corruption of the png when using addLine, but not when using addRGB565Line. I noticed they don't share code and they aren't identical, and copying the "good" code from add565 fixed the issue for me even though I didn't look into what the actual changes are: bd26d990769a3eb213e5bb9d1b68c1c52f242796.

bitbank2 commented 10 months ago

Thanks for finding this. I'm super busy on a bunch of other projects. Can you do a pull request?

prplz commented 10 months ago

Sure! Is it ok if I also make addRGB565Line tail call into addLine to deduplicate the code?

bitbank2 commented 10 months ago

certainly - thanks :)