bitbank2 / Print2BLE

MacOS app which allows drag and drop of images to BLE thermal printers
Apache License 2.0
70 stars 11 forks source link

Support for older MacOS versions #2

Closed LordRembo closed 2 years ago

LordRembo commented 2 years ago

Would it be possible to make this app (or a version of it) compatible with 10.14 (Mojave)? I tried using xcode to export it to other versions but it just gives me errors like these:

/Applications/peripage/Print2BLE/Print2BLE/ViewController.m:46:5: Expression result unused

/Applications/peripage/Print2BLE/Print2BLE/MyBLE.m:112:30: Sending 'MyBLE *const __strong' to parameter of incompatible type 'id<CBPeripheralDelegate> _Nullable'

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreBluetooth.framework/Headers/CBPeripheral.h:62:63: Passing argument to parameter 'delegate' here

bitbank2 commented 2 years ago

I just changed the deployment target to MacOS 10.14 and it worked. It gave a few warnings, but the build succeeds. Did you do something else besides change the deployment target?

LordRembo commented 2 years ago

Well, I had to replace the Team and Signing certificate with one of my own, since I'm not part of the original project 'Team' but that's it. I see it produces a build (in a folder structures like this: ⁨Print2BLE-ehexixkjrohcvtfqlfiwxljawbkb⁩ ▸ ⁨Build⁩ ▸ ⁨Products⁩) but the app just crashes immediately upon trying to open it.

bitbank2 commented 2 years ago

I'm sorry, but I'm not enough of an expert at Mac build issues to debug this. I don't think I'm using any new features, but there were some constants deprecated in the drag and drop part that I recently updated; perhaps that's where the trouble lies.

L.B.