search

bitbank2 / bb_spi_lcd

SPI LCD/OLED library which can be built for Arduino and Linux
GNU General Public License v3.0
89 stars 13 forks source link

src: misc cleanup #13

Closed ardnew closed 7 months ago

ardnew commented 7 months ago

Trailing spaces automatically trimmed by my editor.

Regarding the unused code that was removed, it wasn't clear to me whether the cx and tx values were intended to be used in lines 4350-4356, so I opted to just retain the current behavior.

(edit) To clarify, actual code was removed on lines 4330-4335. The comment above pertains to the removal of these lines.

bitbank2 commented 7 months ago

I'm not sure why you submitted this PR. Removing extra spaces from the code doesn't accomplish anything. I'm sorry, but I'm going to reject this because it doesn't solve a problem that needs solving. Fixing a bug? sure. Adding a feature? Also good, but removing extra blanks?

ardnew commented 7 months ago

@bitbank2 Removing the white space was not the point of the PR. My editor automatically did that, and I figured it couldn't hurt.

Please review the lines I mentioned in the PR description for the actual changes.

Commit 3bd1ee2 has a legitimate change as well (clearly described in the commit message).

bitbank2 commented 7 months ago

I'm sorry, but I've been doing some enhancements and cleanup which I haven't pushed yet. These changes don't warrant a merge.

ardnew commented 7 months ago

Great, hopefully you've cleaned these up too