Closed ardnew closed 7 months ago
I'm not sure why you submitted this PR. Removing extra spaces from the code doesn't accomplish anything. I'm sorry, but I'm going to reject this because it doesn't solve a problem that needs solving. Fixing a bug? sure. Adding a feature? Also good, but removing extra blanks?
@bitbank2 Removing the white space was not the point of the PR. My editor automatically did that, and I figured it couldn't hurt.
Please review the lines I mentioned in the PR description for the actual changes.
Commit 3bd1ee2 has a legitimate change as well (clearly described in the commit message).
I'm sorry, but I've been doing some enhancements and cleanup which I haven't pushed yet. These changes don't warrant a merge.
Great, hopefully you've cleaned these up too
Trailing spaces automatically trimmed by my editor.
Regarding the unused code that was removed, it wasn't clear to me whether the
cx
andtx
values were intended to be used in lines 4350-4356, so I opted to just retain the current behavior.