search

bitbank2 / ss_oled

Simple and small library to control 1-bpp OLED displays (Linux + Arduino)
GNU General Public License v3.0
190 stars 34 forks source link

Use provided OLED address #25

Closed nuthub closed 4 years ago

nuthub commented 4 years ago

When passing iAddr to int oledInit(...), it is not passed to pOLED->oled_addr.

nuthub commented 4 years ago

Thanks for merging the PR.

Please also have a look at the line 768, which does not look correct to me:

pOLED->oled_addr = (uint8_t)scl;
bitbank2 commented 4 years ago

Ugly re-use of a variable specifically for Linux. Unfortunately it is correct.

nuthub commented 4 years ago

SCL feeding into oled_addr? Shouldn't it be

pOLED->oled_addr = (uint8_t)iAddr;

?

bitbank2 commented 4 years ago

It is both wrong and right at the same time :( With my latest changes to the API, it needs to be cleaned up. I'm stuck away from my home (for maybe months now) and don't have an RPI handy to test it. Unless you specifically need it, it will need to stay the way it is until I can rewrite and retest it.

nuthub commented 4 years ago

OK, I was just wondering, if it is correct, because it looked wrong. I just wanted to inform you. Btw, thank you very much for your efforts on that library.