search

bitbank2 / ss_oled

Simple and small library to control 1-bpp OLED displays (Linux + Arduino)
GNU General Public License v3.0
186 stars 34 forks source link

fixing errors in some ucBigFont chars: #$&']^_`| #50

Closed seeess closed 3 years ago

seeess commented 3 years ago

I was using the large font contained in ucBigFont and I noticed some of the symbol characters were incorrect

Specifically: The last row of pixels of characters #&]_ contained the top row of the following characters $'^` instead of a blank line of pixels So I changed the last row of the first set of characters to blank pixels (0x00), then I moved that last row of pixels from the first set of characters to the top row of the second set of characters. And lastly I removed the last row of pixels from the second set of characters so everything lines up.

I also changed the | (pipe) character since it had a break in the middle of it. Maybe you want to reject this part of the pull request if you like the "broken bar" look of the pipe character. But the other part of this PR would still be valid.

bitbank2 commented 3 years ago

Thanks for your help! I was planning on fixing this for a long time. I'll test your changes and merge them soon...

seeess commented 3 years ago

Also the delete char (ascii 0x7f) draws a triangle. Is this expected? I'm not sure if you just want to make that an unprintable/invalid char or something else.

bitbank2 commented 3 years ago

I only put importance on the first 95 characters because the unprintable ones could turn out to be anything. I tested it and it looks good.