bitbank2 / ss_oled

Simple and small library to control 1-bpp OLED displays (Linux + Arduino)
GNU General Public License v3.0
190 stars 34 forks source link

Add oledClearLine using same arguments as oledDrawLine #53

Closed Xorlent closed 2 years ago

Xorlent commented 2 years ago

Provides call to generate a line clear. In this case, used to wipe looping data charts.

bitbank2 commented 2 years ago

I'm wondering if this is the best approach. In my OneBitDisplay library I changed the DrawLine function to take a color parameter instead of creating a new function. ss_oled is really deprecated and OneBitDisplay is in active development. Are you sure you want to proceed with updates to this library?

Xorlent commented 2 years ago

Hi Larry, I was trying to introduce a change that would provide full backward compatibility, as I'm not aware of a clean way to deal with optional arguments. I'm not a programmer, so would obviously defer to your expertise. In my testing the code does appear to work, but I am drawing perfectly vertical lines in this project.

I will take a look at the OneBitDisplay library -- thank you for the suggestion and for your contributions!

bitbank2 commented 2 years ago

I appreciate people trying to help with my projects. I have mixed feelings about adding new things to ss_oled because I have changed my focus to OneBitDisplay. I guess ss_oled still has a purpose because it is a bit smaller code base and will run on an ATtiny85. ss_oled is really a C project pretending to be C++; without a class, it doesn't have access to optional arguments. I'll merge your changes if you make the correction for the other line drawing direction.