search

bitbns-official / node-bitbns-api

This is Official Bitbns API nodeJs Library.
16 stars 19 forks source link

Add Scopes to the Write operations #24

Closed fayazara closed 3 years ago

fayazara commented 3 years ago

I see that there is an option to sell without any 2FA, I believe there should be scopes to disable write operations, this looks extremely unsafe.

sanket-buyhatke commented 3 years ago

hi @fayazara, thanks for your suggestion, could you please elaborate on your suggestion, we would try to integrate it soon.

fayazara commented 3 years ago

What I mean is, giving almost all access to a single token is not safe, if someone wants just read access to their account and do not to do "Sell Order" Write operation, you could give the api keys scopes.

sanket-buyhatke commented 3 years ago

yes, noted thanks for the explanation, will try to implement it in the near future.