bitbof / klecks

Community funded painting tool powering Kleki.com
https://klecks.org
MIT License
220 stars 69 forks source link

Dialogs causing HTMLCanvasElement memory leaks #26

Closed bitbof closed 2 years ago

bitbof commented 2 years ago

The following dialogs cause noticeable memory leaks, creating great amounts of canvas data that never gets garbage collected:

Could be connected to https://github.com/bitbof/klecks/issues/6

bitbof commented 2 years ago

Fixed a leak with https://github.com/bitbof/klecks/commit/be44d4723ea98cd0bd1ee6b48b2d36b6b8960fcc

Dialogs that still cause memory leaks (tested in Firefox, measuring before and after, and manually triggering GC each time):

bitbof commented 2 years ago

All fixed with

https://github.com/bitbof/klecks/commit/be44d4723ea98cd0bd1ee6b48b2d36b6b8960fcc https://github.com/bitbof/klecks/commit/0c25336972e92f8ffde7febd16d0b5f03fb12dc6 https://github.com/bitbof/klecks/commit/e9521cdbeca5de62669606beb153a60637a16b85 https://github.com/bitbof/klecks/commit/3412ed129f429f9fd0a5adb367e0f6fa0e9b0397