bitbof / klecks

Community funded painting tool powering Kleki.com
https://klecks.org
MIT License
220 stars 69 forks source link

Multiple “Edit” functions not working #74

Closed SplatSys closed 1 year ago

SplatSys commented 1 year ago

(Broken as of 4/27/22 (April 27th)) For the purposes of hardware/browser info if it is needed, I am encountering this issue on a (school-owned) Lenovo 300e Chromebook (2nd Gen) with the Chrome browser. I have not run into this issue on my personal Chromebook— a HP X360– which also runs on the Chrome browser.

In the “Edit” tab, the following tools are all experiencing this issue; Perspective, Bright/Contrast, Curves, Hue/Saturation, Invert, Distort, Noise (Invert, Distort, and Noise have a slightly different case, which I will explain), Tilt Shift, To Alpha, Triangle Blur, and Unsharp Mask.

All of the above tools, which normally have a special menu, do not have this menu. Excluding Invert, Distort, and Noise, the pop-up for the menus show, they it only contain the text explaining what the tool does, the Okay/Cancel buttons, and the close button in the top right. There are no sliders anywhere for actually using the tool. Pressing the Okay button does not do anything, and undoing does not track that anything has changed because of this.

Invert has a main browser pop-up reading; “Couldn’t apply the edit action” and an in-site notification (like the undo/redo ones) that contradicts this, saying “Invert applied.” This also causes the undo and redo functions to bug out and not properly register inputs.

Distort and Noise, when clicked, do absolutely nothing. No windows show or anything.

Everything else on the site seems to be working as intended, but this issue makes the site borderline unusable when I’m at school.

bitbof commented 1 year ago

Hi, thanks for this detailed report. It sounds like WebGL might not currently be supported by Chrome on your 300e Chromebook. What do you see when you visit this page? https://get.webgl.org/

It should look like this:

image

If not, that will make all of the above listed Edit functions fail as they use WebGL. I will try to provide better feedback about this in the app in the future.

SplatSys commented 1 year ago

Hey there! Thanks for the quick reply. Yes, the spinning cube does show up. I've tried restarting my Chromebook as well as clearing the cache, but that didn't fix anything. It worked in the past and only stopped working maybe 2-4 days ago, but my Chromebook hasn't updated in that timespan, so I'm not sure what could've caused this. image I meant to attach an image, but I couldn't because I was still at school at the time, but this is the popup that happens when any of the tools are clicked on, just with dialogue respective to each tool.

bitbof commented 1 year ago

Yes, the spinning cube does show up

That is on the Lenovo with the above described issue, correct? That would be indeed surprising.

SplatSys commented 1 year ago

Yes, the spinning cube does show up

That is on the Lenovo with the above described issue, correct? That would be indeed surprising.

It is.

bitbof commented 1 year ago

Ok! If you don't mind, when on Kleki/Klecks, could you open the dev tools (press F12) and go into the console tab, to see if there are errors? And what is your Chrome version?

Beyond that I will try to investigate this myself.

Thanks!

SplatSys commented 1 year ago

Ah, minor issue with that. I don't seem to be able to use the F12 shortcut on the Chromebook experiencing this error. I checked to make sure it was the correct command input, but it doesn't seem to be working. The Chromebook experiencing this is on version 112.0.5615.134 according to what my settings say. I haven't restarted to finish the update on my personal Chromebook yet, so I'm going to do that and see if it's a Chrome issue.

Update; I did the reset and checked the broken tools on my personal Chromebook, and they still work, so it seems to just be my school device.

bitbof commented 1 year ago

Thanks a lot. I think it might be that school laptops don't allow students to open the dev tools. Regardless this has been a lot of useful info. I'll delve more into this the coming days.

SplatSys commented 1 year ago

Alright! Thank you again for the quick response, it means a lot, and thank you for creating such a useful program. Honestly, the best open-sourced art program I've ever used!

bitbof commented 1 year ago

@SplatSys Do you observe the same problem here? https://644e2e87cbc6c42f7c1d0f36--bb-sandbox.netlify.app/

It is an older version from before I made big changes to the Edit functions.

SplatSys commented 1 year ago

As of right now, I'm not able to provide updates on this. My school messed up something with its security extension and somehow managed to block literally every site (even canvas and stuff, lol???). I'll check this as soon as I am able to, but I'm not quite sure when that'll be.

SplatSys commented 1 year ago

https://644e2e87cbc6c42f7c1d0f36--bb-sandbox.netlify.app/

Yes, the same issue happens here.

bitbof commented 1 year ago

Ok, thank you for checking!

bitbof commented 1 year ago

Today the problem became widespread. Pretty much all seem to be ChromeOS + Chrome 112. A Chrome OS problem? Some new school regulations that disable WebGL on student laptops? I'm not sure.

SplatSys commented 1 year ago

It's... odd. It still works fine on my personal Chromebook, and WebGL is still functional on my school one, so I'm not quite sure. I've given you as much info as I can, but if you have anything else you think I could be able to share, please let me know.

JukeMix commented 1 year ago

it just now effected me, same thing it shows that WebGL works but some edit buttons dont work, so it maybe some os problem oh and im using my own personal chromebook for kleki and it's a samsung chromebook so it maybe slowly effecting other chromebooks too

bitbof commented 1 year ago

I am pretty stumped that the WebGL test page works for you, but Kleki doesn't. And I can't reproduce the error on any of my devices.

I made my own test page, that only tries to start WebGL. What do you see on this page? https://bitbof.com/stuff/2023-05-04-webgl-test/

Also here is the last deployed version of Kleki where the error did not occur. (the one I linked above was newly built, maybe the build process screwed something up) Do the filters fail here too? https://64058fa26b6b050008ba8a05--kleki-yh6qfdn4n4m8.netlify.app/

SplatSys commented 1 year ago

The WebGL test page works. The Kleki issue is still present in the version you sent.

JukeMix commented 1 year ago

same here

RyeRyeRasputin commented 1 year ago

This keeps getting weirder all the WebGL test pages work just fine but kleki appears to say otherwise?? Screenshot 2023-05-06 8 31 49 PM

bitbof commented 1 year ago

Yea it is pretty weird, especially because it affects older Kleki versions too despite them working fine last month.

This is a long shot: Could you temporarily disable all extensions and see what happens?

RyeRyeRasputin commented 1 year ago

Yea it is pretty weird, especially because it affects older Kleki versions too despite them working fine last month.

This is a long shot: Could you temporarily disable all extensions and see what happens?

I don't have any extensions that could be interfering I know little to nothing about tech but my guess is maybe a checker code in kleki isn't working correctly & is breaking everything with a false WebGL test?? i dunno if that could even happen or if kleki has any code like that Btw is this supposed to happen? Screenshot 2023-05-06 10 42 48 PM

SplatSys commented 1 year ago

Unable to get on the device with the broken version at the moment, but this is even more confusing to me, as my personal Chromebook is still completely unaffected.

I'm unable to disable all extensions on my school Chromebook due to how the settings on it are set up.

bitbof commented 1 year ago

I reported the issue as a potential Chrome bug, since code that previously worked, fails now: https://bugs.chromium.org/p/chromium/issues/detail?id=1443160

My other theory is that an extension might interfere with the page.

Also I updated Kleki. It now gives clear feedback if WebGL fails and should not break in strange ways because of that anymore.

satopian commented 1 year ago

@bitbof image The content of the error is different, so it may be completely unrelated, but the cause of the webGL-related trouble I encountered was a bug in the graphics driver.

Crash in Intel HD 630 driver - Intel Communities

This link is an example of WebGL crashing due to a bug in Intel's graphics driver. I thought that if Chromebook issues were specific to a specific manufacturer, it might have something to do with the graphics board and the graphics drivers installed, but this is just a guess based on my experience. Sorry if it doesn't matter.

bitbof commented 1 year ago

That's true, driver issues are possible too.

bitbof commented 1 year ago

In the reported issue they wrote the following: "Please gather the plaintext contents of about:gpu from machines where this is failing. Here's an example. This is the only way to diagnose what's going wrong on these users' machines."

If you want to help them diagnose the problem please share what you see when you type "about:gpu" into the address bar. Share it either here, in the reported issue (https://bugs.chromium.org/p/chromium/issues/detail?id=1443160), or you can email it to me and I'll post it there. I fully understand if you don't want to do that.

SplatSys commented 1 year ago

Haven't had time recently to check on this thread, but since the implementation of the WebGL failure feedback, my personal Chromebook- which was fine before this update- now also shows that WebGL is failing, when it had seemed to be unaffected beforehand.

I posted the plaintext file for the originally affected Lenovo 300e (gen 2) Chromebook in the reported issue you linked, and I'll try to keep an eye on both pages a little better, haha!

bitbof commented 1 year ago

Big thanks to you @SplatSys . Looks like things are happening. 👍

I will close this once the number of users with this problem is declining.

JukeMix commented 1 year ago

IT"S FIXED NOW

SplatSys commented 1 year ago

Hey! Update from me. The edit menus have been restored on both devices, including the one that was initially experiencing this issue! I'm glad everything has gotten mostly situated.

Thank you so much for having gotten on this issue so quickly. I really, really appreciate it.