bugfixes: wrong #ifdef sequence, bool function misses return

[tgracin]

Some typos I encountered, at least they seem so.

[skarlsson]

Well, thanks - it was a bug even if you closed the pull request - fixed.

However I realize you are compiling under windows - I haven't done that for several months so I might have some more bashing to come...

2017-12-06 15:37 GMT+01:00 Tomislav Gracin notifications@github.com:

Closed #10 https://github.com/bitbouncer/kspp/pull/10.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitbouncer/kspp/pull/10#event-1374900604, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKn8p6InJp7lsM7HqUlVf_WJH6aPtVZks5s9qaogaJpZM4Q4Adv .

[tgracin]

I closed it because you fixed an issue I submitted - so I wanted to re-submitt a clean pull request so you don't have to solve conflicts yourself. But then, you solved both of them without me :).

Yes, I am trying to build it under Windows, and there are/were some problems. For example, in latest version avro_serves.h you include files which aren't in repo:

#include <avro/Encoder.hh>
#include <avro/Decoder.hh>
#include <avro/Compiler.hh>
#include <avro/Generic.hh>
#include <avro/Specific.hh>

So now I am focusing on v0.7.6

[skarlsson]

Those are in avro. (apache) . I'll try to build on windows tomorrow.

On Dec 6, 2017 15:57, "Tomislav Gracin" notifications@github.com wrote:

I closed it because you fixed an issue I submitted - so I wanted to re-submitt a clean pull request so you don't have to solve conflicts yourself. But then, you solved both of them without me :).

Yes, I am trying to build it under Windows, and there are/were some problems. For example, in latest version avro_serves.h you include files which aren't in repo:

include <avro/Encoder.hh>

include <avro/Decoder.hh>

include <avro/Compiler.hh>

include <avro/Generic.hh>

include <avro/Specific.hh>```

So now I am focusing on v0.7.6

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitbouncer/kspp/pull/10#issuecomment-349664285, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKn8lJR_Y_FdebB1fPt65X_rHN8FnIdks5s9qtygaJpZM4Q4Adv .

[skarlsson]

btw avro was required a couple of releases ago so 0.7.6 will not help you. I have the build instructions for windows somewhere and I get them tomorrow. I dropped windows in June and switched to Linux and clion

2017-12-06 22:55 GMT+01:00 Svante Karlsson svante.karlsson@csi.se:

Those are in avro. (apache) . I'll try to build on windows tomorrow.

On Dec 6, 2017 15:57, "Tomislav Gracin" notifications@github.com wrote:

I closed it because you fixed an issue I submitted - so I wanted to re-submitt a clean pull request so you don't have to solve conflicts yourself. But then, you solved both of them without me :).

Yes, I am trying to build it under Windows, and there are/were some problems. For example, in latest version avro_serves.h you include files which aren't in repo:

include <avro/Encoder.hh>

include <avro/Decoder.hh>

include <avro/Compiler.hh>

include <avro/Generic.hh>

include <avro/Specific.hh>```

So now I am focusing on v0.7.6

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitbouncer/kspp/pull/10#issuecomment-349664285, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKn8lJR_Y_FdebB1fPt65X_rHN8FnIdks5s9qtygaJpZM4Q4Adv .

[skarlsson]

forgot to say, I appreciate support! (even if it's windows)

2017-12-07 0:45 GMT+01:00 Svante Karlsson svante.karlsson@csi.se:

btw avro was required a couple of releases ago so 0.7.6 will not help you. I have the build instructions for windows somewhere and I get them tomorrow. I dropped windows in June and switched to Linux and clion

2017-12-06 22:55 GMT+01:00 Svante Karlsson svante.karlsson@csi.se:

Those are in avro. (apache) . I'll try to build on windows tomorrow.

On Dec 6, 2017 15:57, "Tomislav Gracin" notifications@github.com wrote:

I closed it because you fixed an issue I submitted - so I wanted to re-submitt a clean pull request so you don't have to solve conflicts yourself. But then, you solved both of them without me :).

Yes, I am trying to build it under Windows, and there are/were some problems. For example, in latest version avro_serves.h you include files which aren't in repo:

include <avro/Encoder.hh>

include <avro/Decoder.hh>

include <avro/Compiler.hh>

include <avro/Generic.hh>

include <avro/Specific.hh>```

So now I am focusing on v0.7.6

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitbouncer/kspp/pull/10#issuecomment-349664285, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKn8lJR_Y_FdebB1fPt65X_rHN8FnIdks5s9qtygaJpZM4Q4Adv .