search

bitbubbler / yet-another-dcs-server

YADS: A work in progress dcs server
The Unlicense
5 stars 3 forks source link

solve windows paths with spaces issue by switching to execFile? #17

Closed bitbubbler closed 2 years ago

bitbubbler commented 2 years ago

attempt to solve #16

bitbubbler commented 2 years ago

@SerpentSouris26 can you try this branch?

bitbubbler commented 2 years ago

@SerpentSouris26 can you try this branch?

nevermind, it's failing ci. I'll have another look at the ci failure this evening

bitbubbler commented 2 years ago

Ok. @SerpentSouris26 can you try this branch now? Ci is passing for windows

bitbubbler commented 2 years ago

this seems to be working on a test windows box i cobbled together, going to merge

SerpentSouris26 commented 2 years ago

I did a trial and modifications done in generate-type.js did not solve the issue. Still have : 

PS C:\Users\benmi\Saved Games\DCS-gRPC workspaces\yet-another-dcs-server> npm run codegen
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.

> codegen
> node generate-types.js

failed Error: Command failed: C:\Users\benmi\Saved Games\DCS-gRPC workspaces\yet-another-dcs-server\node_modules\.bin\proto-loader-gen-types -I C:\Users\benmi\Saved Games\DCS-gRPC workspaces\yet-another-dcs-server\src\proto -O C:\Usenother-dcs-server\src\proto -O C:\Users\benmi\Saved Games\DCS-gRPC workspaces\yet-another-dcs-server\generated --oneofs --grpcLib=@grpc/grpc-js C:\Users\benmi\Saved Games\DCS-gRPC workspaces\yet-arotonother-dcs-server\src\proto\dcs\dcs.proto
'C:\Users\benmi\Saved' n'est pas reconnu en tant que commande interne
ou externe, un programme ex�cutable ou un fichier de commandes.

    at ChildProcess.exithandler (node:child_process:398:12)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
  code: 1,
  killed: false,
  signal: null,                                                                                                                                                                                     s-server\\src\\proto -O C:\\Users\\be
  cmd: 'C:\\Users\\benmi\\Saved Games\\DCS-gRPC workspaces\\yet-another-dcs-server\\node_modules\\.bin\\proto-loader-gen-types -I C:\\Users\\benmi\\Saved Games\\DCS-gRPC workspaces\\yet-another-dcs\\dcs.proto',s-server\\src\\proto -O C:\\Users\\benmi\\Saved Games\\DCS-gRPC workspaces\\yet-another-dcs-server\\generated --oneofs --grpcLib=@grpc/grpc-js C:\\Users\\benmi\\Saved Games\\DCS-gRPC workspaces\\yet-another-dcs-server\\src\\proto\\dcs\\dcs.proto',
  stdout: '',
  stderr: "'C:\\Users\\benmi\\Saved' n'est pas reconnu en tant que commande interne\r\n" +
    'ou externe, un programme ex�cutable ou un fichier de commandes.\r\n'
}
PS C:\Users\benmi\Saved Games\DCS-gRPC workspaces\yet-another-dcs-server>