MISC: BitNode options

[catloversg]

This PR adds a new feature: BitNode options. When the player enters a BN, they can set custom BitNode options:

• Active level of SF: change the effective level of SFs. For example, if the player has SF12.1000, they can set a custom level and enter a BN without NFG-1000. It also allows the player to create custom "scenarios", e.g., "I have all SFs now. How long do I need to beat BN1 with only SF1, SF4, and SF5?".
• Disable some features. These options are based on the conditions of BN challenges.

Intentional changes:

• knowsAboutBitverse is renamed to knowAboutBitverse and moved to BitNodeUtils.ts. It replaces all checks of Player.sourceFiles.size > 0.
• canAccessBitNodeFeature is moved to BitNodeUtils.ts. It replaces all checks of Player.bitNodeN === n || Player.sourceFileLvl(n) > 0.
• All usages of Player.sourceFileLvl and Player.activeSourceFileLvl are intentional.
• gainIntelligenceExp: Remove this.skills.intelligence > 0. This check comes from the ancient commit e3991b8795fc9bccd38240e17c99e6d20d53fd4f. It's irrelevant now. The player cannot earn intelligence exp if they are not in BN5 and do not have SF5.
• The refactor of Sleeve.ts and Person.ts: I moved functions in [X]Methods.ts to [X].ts when I started to implement the disableSleeveExpAndAugmentation option. That change is unnecessary now, so I will revert it if the maintainers want.

Test case

Normal gameplay: Check SF level and active SF level after entering a new BN:

• Finish the BN:
  • Hack WD via Terminal.
  • ns.singularity.destroyW0r1dD43m0n.
  • Bladeburner.
• Bitflume:
  • b1t_flum3.exe.
  • ns.singularity.b1tflum3.

Change active SF level:

• Check SF level and active SF level after entering a new BN.
• Check effects of SF. For example, set SF3 to level 0, and check if we can create a corporation outside of BN3.

Change boolean options:

• Restrict Home PC upgrade:
  • Check UI of vendor.
  • ns.singularity.upgradeHomeRam and ns.singularity.upgradeHomeCores.
• Disable XYZ: Check if XYZ is available. For example:
  • Enter BN3, and check if we can create a corporation.
  • Set SF3 to level 3, enter BN1, and check if we can create a corporation.
• Disable 4S Market Data:
  • Check UI of Stock Market.
  • ns.stock.purchase4SMarketData and ns.stock.purchase4SMarketDataTixApi.
• Disable Sleeves' exp and augmentation:
  • Check UI of Sleeves.
  • Functions in ns.formulas.work.

Screenshot

[d0sboots]

High-level comments before I dive into the code:

• Sorry I put this off for a while.
• I like the overall concept!
• The description text confused me at first. Here's my attempt at explaining: "Note: Changing the active level of a SF is temporary, you still permanently own that SF level. For example, if you enter BN 1.3 while having SF 1.2 but with the active level set to 0, you will not get the bonuses from SF1.1 or 1.2 but you will still earn SF1.3 when destroying the BN."
• It would be good to see what the options look like if you don't have all SFs yet.
• I think the "Active level" text should only show if it's less than the current max, otherwise it's just noise.

[d0sboots]

I don't know if you've been following allong in #development, here's some other comments that came from discussion there:

• The toggles should be moved before the detailed SF settings, since they're more likely to be used.
• It would be good to have an "All SFs" setting, even if it just serves to set all the SFs to a specific level without having to click them all manually. But as someone mocked up, it would be nice if you could express the changes as a set of overrides, instead of an individual UI setting for each SF. This plays into what Snarling suggested for the storage representation as well.
• We talked about UI stuff as well, such as using an expand-o box instead of a toggle. I think that would be more natural, but one consideration is how these settings will be preserved (or not) when you beat the BN. Using a toggle means you could save the settings, but have them be default disabled for the next BN.

[catloversg]

New UI:

Advanced options are cleared when the player switches between targeted BitNodes. They are also not persisted in Settings. This is intentional. IMO, a minor inconvenience is better than "Oops! I forgot resetting those options!".

[d0sboots]

UI is starting to look pretty good, or at the minimum, good compared to many of our UIs XD

I agree with your reasoning on not saving the settings. Especially with the new-style of adding individual SFs.

Some other UI thoughts: We should add tooltips for the toggles. What, exactly, "Restrict home PC upgrade" entails isn't clear without extra words. Extra words can also make it clear that "Disable hacknet servers" means "Reenable hacknet nodes".

For the buttons, IMO we should do more graphically and less with text. I'm assuming "level" means "current owned level of this SF" - that should be expressed by number of buttons. (There's no point having a button you can't click on.) If you don't have the SF, you shouldn't be able to add it, and if you only have 1 level you only get one button.

Similarly, the currently active level should use a bright highlight or something - standard "button selected" stuff. That eliminates the need for the extra text and IMO will be easier to visually understand.

[d0sboots]

One other suggestion that I needed to read the code first to make: IIUC, the "Set all SF" button isn't a setting of its own, but rather it immediately creates/sets the SF setting for all possible values. It's not what I was initially expecting, but I think it's fine. However, in that case it should get an additional "X" or trashcan button to remove all SF settings so that the state is back to default.

[jjclark1982]

Should there be a toggle to enter a BitNode with no Intelligence (without disabling SF5 features)? And how should the results merge with previous Intelligence?

A reasonable scenario for comparing speed-runs would be "How long does it take to complete BitNode N with all features unlocked and no starting Intelligence?" so disabling SF5 is not a great option as it removes Formulas.exe at start and Intelligence gain within the node, which are changes to strategy.

[catloversg]

New UI:

UI changes:

• Restrict Home PC upgrade -> Restrict max RAM and core of Home PC. Change the tooltip text.
• Disable Hacknet Server: Change the tooltip text.
• Add Remove all + tooltip.
• Add tooltip for Set all SF.
• Only show relevant buttons.
• Highlight the active level.

[catloversg]

Should there be a toggle to enter a BitNode with no Intelligence (without disabling SF5 features)? And how should the results merge with previous Intelligence?

A reasonable scenario for comparing speed-runs would be "How long does it take to complete BitNode N with all features unlocked and no starting Intelligence?" so disabling SF5 is not a great option as it removes Formulas.exe at start and Intelligence gain within the node, which are changes to strategy.

I can add "Disable Intelligence bonus". That option will only disable the bonus of Intelligence (calculateIntelligenceBonus). I'll add it if d0sboots and Snarling agree.

[d0sboots]

I can add "Disable Intelligence bonus". That option will only disable the bonus of Intelligence (calculateIntelligenceBonus). I'll add it if d0sboots and Snarling agree.

That seems like a good way to handle it: you still gain int (if applicable), it just has no effect. It might need a UI bit though, otherwise it'll look like you have normal int and won't be obvious that it's disabled. Maybe strikethrough where int is displayed?

I think @Snarling has yet to sign off on the overall design, but I would encourage him to (I'm not going to merge this one without some kind of thumbs up).

[catloversg]

Snarling mentioned that they would release v2.6.2 soon. This PR is a bit large, so it's best to merge it after that. I want it to be tested in the dev branch for a bit longer.