search

bitburner-official / bitburner-src

Bitburner source code.
Other
688 stars 232 forks source link

INFILTRATION: Follow-up of #1414 #1441

Open catloversg opened 1 week ago

catloversg commented 1 week ago

Snarling merged #1414 before I could commit this change, so I submitted it as a separate PR.

I agree with some of Snarling's points in #1414. Generally, we should not play the whack-a-mole game with our players when it comes to UI-based exploits like automated infiltration. Just as Snarling said, the protections in that PR can be bypassed, and it's hard to make it bulletproof. However, IMO, it's too easy to bypass the new check. The popular automated infiltration script only needs to add 1 line to bypass the check. This PR adds 1 more protection layer.

I understand that this change makes it look like we are starting an unnecessary "fight" with our players. I agree that we should not add more and more protection layers because they will eventually find a way to bypass our checks. I'm fine if this PR is closed.

d0sboots commented 1 week ago

Yeah, IMO this one is a step too far.

Edit: Rationale: The other ones are defined not for security, but because it's otherwise easy to step on them by accident (with a typo) and cause the game to crash. Locking stuff down for that purpose makes sense. Beyond that, IMO it doesn't make sense.