search

bitburner-official / bitburner-src

Bitburner source code.
Other
847 stars 274 forks source link

DOCUMENTATION: Insufficient alternative for ns.go.analysis.getValidMoves() #1576

Open bupjae opened 3 months ago

bupjae commented 3 months ago

Currenr dev branch

https://github.com/bitburner-official/bitburner-src/blob/23f98c1ff6cbff0953dd6ce348433a3d5aa2d851/markdown/bitburner.goanalysis.getvalidmoves.md?plain=1#L26

We also have to determine getMoveHistory() to comply no-repeat rule.

https://github.com/bitburner-official/bitburner-src/blob/23f98c1ff6cbff0953dd6ce348433a3d5aa2d851/src/Go/boardAnalysis/boardAnalysis.ts#L46-L47

The comment says only one board of history is checked, but the code actually checks full history.

d0sboots commented 3 months ago

You might want to open this as either an issue or a PR, commenting on the repo will get lost.

bupjae commented 3 months ago

I think I just created (= open?) the issue, including current repo as link.

I didn't know it is possible to comment on the repo directly.

d0sboots commented 3 months ago

Oh weird, this is an issue. I was just brain-farting when looking at it.

Yeah, it is possible to comment on the repo directly. I'm not sure how, but I've seen it done by someone in a different repo that I have notifications on. XD