search

bitburner-official / bitburner-src

Bitburner source code.
Other
847 stars 274 forks source link

ns.sleeve.setToBladeburnerAction does not provide the list of actions in the method signature #1581

Closed ficocelliguy closed 3 months ago

ficocelliguy commented 3 months ago

Recording this issue for Venusaur based on the discussion on the discord suggestions channel https://discord.com/channels/415207508303544321/415213435974975508/1273346517679472731

Currently setToBladeburnerAction does not offer any help as to what strings are valid actions:

image

Compare this to sleeve.travel(): image

A type could be added to the NetscriptDefinitions file similar to CityName https://github.com/bitburner-official/bitburner-src/blob/dev/src/ScriptEditor/NetscriptDefinitions.d.ts#L7797

Note that this type should probably be also copied and used in the code that handles the actual sleeve code: https://github.com/bitburner-official/bitburner-src/blob/dev/src/PersonObjects/Sleeve/Sleeve.ts#L482

bupjae commented 3 months ago

For the note, the following sleeve function could be improved with same way:

setToUniversityCourse(sleeveNumber: number, university: string, className: string): boolean; setToGymWorkout(sleeveNumber: number, gymName: string, stat: string): boolean;

university and gymName: subset of LocationName className: UniversityClassType stat: GymType