bitburner-official / bitburner-src

Bitburner source code.
Other
837 stars 273 forks source link

BLADEBURNER: UI now shows tooltips on action success chance to show stat scaling #1699

Closed Alpheus closed 1 month ago

Alpheus commented 1 month ago

BLADEBURNER: UI now shows tooltips on action success chance to show stat scaling

Hovering over the "estimated success chance" text now shows what stats it scales from. Plus description for Black Ops to keep them focused on the lore text.

Motivation

Joining bladeburner requires 100 combat stats but it's never explained how or why it is relevant to gameplay. Hoping this tooltip will help connect the dots.

Looking for review/feedback on:

d0sboots commented 1 month ago

Can you add a screenshot of the tooltip in action? Also, what happens when there's no text? It looks like it'll make an empty tooltip, probably better to not have a tooltip in that case.

Aside from that, looks good.

Alpheus commented 1 month ago

Can you add a screenshot of the tooltip in action? Also, what happens when there's no text? It looks like it'll make an empty tooltip, probably better to not have a tooltip in that case.

Aside from that, looks good.

I checked the docs for nullish titles and this is what they claim:

-- -- -- -- Tooltip title. Zero-length titles string, undefined, null and false are never displayed.

from: https://mui.com/material-ui/api/tooltip/

Is the wrapped empty component an issue? I can cycle it out with a ternary but it becomes much harder to read (relative to the existing simplicity)

Screenshot: image

d0sboots commented 1 month ago

Is the wrapped empty component an issue? I can cycle it out with a ternary but it becomes much harder to read (relative to the existing simplicity)

Nope, that's fine then.