search

bitburner-official / bitburner-src

Bitburner source code.
Other
837 stars 273 forks source link

GANG: Show confirmation popup if player enables territory clashes while being too weak #1760

Closed catloversg closed 2 weeks ago

catloversg commented 2 weeks ago

In the past, the player could enable territory clashes in the main page of Gang UI (Management tab). We removed that toggle, so now the toggle is only on the Territory tab.

I accidentally stumbled on the old (heated) discussion about this change. I agree that having that toggle on the main page is a newbie trap. After reading the whole discussion, I want to implement the second point of Snarling's idea in this comment: https://discord.com/channels/415207508303544321/459097632896188436/1149047761044512799.

Quote:

Warning dialog? I think it would be a huge improvement to implement a conditional warning dialog for enabling territory warfare if the player has less than a 50% chance to win clashes. Attempting to enable while you have a <50% chance of winning is a pretty good indicator that the player does not know what they're doing and are about to ruin their gang. If they have a >=50% chance to win clashes, no reason to show a dialog because the player seems to know what they are doing. Simple dialog like "You are about to enable Territory Warfare, but you only have a 42% chance to win Territory Clashes, are you sure? Y/N". I don't think the cooldown where clash chance slowly falls back down to 0% is the important thing to highlight here, since that's not what makes enabling warfare a bad decision.

Screenshot: Capture

d0sboots commented 2 weeks ago

Ah yes, that infamous discussion.

Glad you circled around to address this. Everything looks good, aside from that one quirk.