HP calculation regarding BladeRunner actions seems buggy

[TheMas3212]

[EinHuhu] There seems to be (at least) one bug in the HP calculation regarding blade runner actions. I noticed HP going down for a different value than reported in the log, the Hyperbolic Regeneration Chamber being unable to heal up and some other odd things.

I had this several times now but cannot exactly tell what triggers this. The following example is from the latest steam client ('v1.7.0 (00adc2ff)'), but had it also with previous versions.

This example happened some minutes after aug installation in BN 13. After installing new augmentations, I did some rounds of blade runner Training and switched then to Field Analysis while charging Stanek's gift. After charging, I switched blade runners action to Retirement to both train the combat skills and get some money to boost the hacknet servers. I had to reduce the level for this since the combat skills were not yet high enough for the max level I have. Since the combat skills rise fast and I don't want to adapt the level after each run, I went for an estimated success chance ~95% when a contract failed (can happen, can be cured again.. so what ..)

The point here is:

• a damage of 7 HP was reported, but my HP were reduced from 21 to 11 (that's not a difference of 7, right!?).
• I started some rounds of Hyperbolic Regeneration Chamber to heal up again. As shown in the attached screenshot, the regeneration chamber healed once and then stopped doing anything.
• I let the Hyperbolic Regeneration Chamber run to show that it should have regenerated more HP than is reported as my current health in the overview.
• I wasn't doing anything else in between that has any impact on combat skills (no infiltrations, no crimes, no training, no work, charging stanek's gift was done)
• After restarting Retirement and getting more combat skills, the HP in the overview went back to a difference of 10 (e.g. 24/34) and stayed there (no more failure happened).
• When going back to Hyperbolic Regeneration Chamber, the HP went from 24 to 25 after the first run, to 27 after the second, to 31 after the third and eventually reached the full 34 HP after the fifth run.

I exported a save game after the creation of the screenshot (before restarting the retirements), so I can provide this too if needed.

Comments From Original Issue

[EinHuhu]

Next aug installation, same issue. This time 5 damage are reported, but only 3 are subtracted

[catloversg]

@d0sboots We can close this bug:

• It was reported in a very old version.
• I cannot reproduce the problem of "a damage of 7 HP was reported, but my HP were reduced from 21 to 11" in both the reported version and the current version.
• I don't understand the problem with Hyperbolic Regeneration Chamber. When HP is less than max HP, it regenerates HP properly. It always shows "Restored 2 HP", even when HP is fully recovered, but it is expected. We can change it, but it's a different matter.
• "When going back to Hyperbolic Regeneration Chamber, the HP went from 24 to 25 after the first run, to 27 after the second, to 31 after the third and eventually reached the full 34 HP after the fifth run.". I can reproduce this problem in the reported version, but it's a bug in StaneksGift.ts. Staneks Gift's effects do not apply properly, so defense_mult constantly changes. It makes HP and max HP change slightly in some cases. This bug was fixed a long time ago. I cannot reproduce it in the current version.