search

bitcanon / visonicalarm

A simple library for the Visonic Alarm API written in Python 3.
MIT License
12 stars 2 forks source link

Don't store credentials in memory #15

Closed bitcanon closed 2 years ago

bitcanon commented 2 years ago

It's bad security practice to store email, password and user code in memory inside the library. Remove the local variables from core.py and make it up to the user to decide where to store the credentials:

self.__user_code = user_code
self.__app_id = user_id
self.__panel_id = panel_id
self.__user_email = user_email
self.__user_password = user_password