feat(webapp): new registration and login flow

gaboesquivel commented 2 months ago

Summary by Sourcery

Implement a new registration and login flow for the web app using Bitcash, combining both processes into a single interface. Simplify session dialog management by removing state handling for dialog content and update the session button to support the new flow.

New Features:

Introduce a unified login and registration flow using Bitcash, allowing users to either log in or register through a QR code scan.

Enhancements:

Update the session dialog to remove the need for state management of dialog content, simplifying the component structure.
Enhance the session button to reflect the new combined login and registration functionality.

Summary by CodeRabbit

New Features
- Updated the login dialog to support both login and registration actions.
- Enhanced clarity in user prompts and navigation options within the dialog.
- Replaced the button with a link directing users to a blog post about the Bitcash KYC process.
- Modified the session button label to indicate dual functionality for login and registration.
Bug Fixes
- Streamlined dialog content display logic, ensuring a consistent user experience.
Documentation
- Improved user guidance within the dialog for better engagement and understanding.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
bitlauncher	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 4, 2024 7:44pm
smartsale-faucet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 4, 2024 7:44pm

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request implements a new registration and login flow for the webapp. The changes primarily focus on simplifying the login process, removing the separate registration flow, and updating the UI to reflect these changes. The implementation also includes improvements to the QR code generation for login and updates to the session management hooks.

File-Level Changes

Change	Details	Files
Simplified login and registration process	Removed separate registration dialog content Updated SessionDialogContent to handle both login and registration Changed dialog title and description to reflect combined login/register functionality Removed 'Get Bitcash App' button and replaced with a link to learn about KYC process	`apps/webapp/components/dialogs/session/login-dialog-content.tsx` `apps/webapp/components/dialogs/session/session-dialog.tsx`
Updated QR code generation for login	Modified loginUri generation to include registration URI and ESR code Added console log for loginUri	`apps/webapp/hooks/use-session.tsx`
Updated UI components to reflect new login/register flow	Changed 'Login' button text to 'Login / Register' Removed unused router import	`apps/webapp/components/dialogs/session/session-button.tsx`
Refactored referral handling	Simplified code for handling referrer parameter Updated bitcash register URI generation	`apps/webapp/hooks/use-referral.ts`

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve significant updates to the session management components within the web application. The SessionDialogContent now focuses on both login and registration, simplifying the interface by removing unnecessary props. The dialog's title and description have been refined for clarity, and the referral logic has been enhanced for configurability based on the application environment. Additionally, the login URI construction and styling configurations have been improved.

Changes

Files	Change Summary
`apps/webapp/components/dialogs/session/login-dialog-content.tsx`	Removed `updateDialogContent` prop, updated dialog title and description for clarity, replaced button with a link to a blog post about KYC.
`apps/webapp/components/dialogs/session/session-button.tsx`	Updated button label from "Login" to "Login / Register" and removed unnecessary routing logic.
`apps/webapp/hooks/use-referral.ts`	Introduced `DEFAULT_URI` and `DEFAULT_REFERRER`, updated state initialization and session storage logic for improved configurability.
`apps/webapp/hooks/use-session.tsx`	Modified login URI construction by removing 'esr://' prefix from encoded string and added console log for debugging.
`apps/webapp/hooks/use-signing-request.ts`	Changed URL parameter name from `esr_code` to `esr` in redirect logic.
`apps/webapp/tailwind.config.js`	Updated `accent` color from a variable reference to a hardcoded color value.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SessionDialog
    participant SessionDialogContent
    participant useSession

    User->>SessionDialog: Open dialog
    SessionDialog->>SessionDialogContent: Render login content
    SessionDialogContent->>useSession: Get login URI
    useSession-->>SessionDialogContent: Return login URI
    SessionDialogContent->>User: Display QR code and instructions

🐰 In the meadow, I hop with glee,
New changes sprout like flowers, you see!
Login and register, all in one place,
With a QR code, join the race!
A link to learn, oh what a treat,
Hoppity hop, our journey's complete! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

AndlerRL commented 2 months ago

@gaboesquivel -- I made some changes on the loginUri for both desktop and mobile. I made sure to use the search parameter esr on both scenarios and I improved the environments for this URI to test. The app should receive them with no issues. If an issue is found, @AnoukRImola and the rest of the team can report to us.

cc - @merivercap

bitcashorg / smartsale