Open codexnakamoto opened 1 year ago
oh wow i just saw the little lightbulb, it's really difficult to spot. i will investigate having it default correctly if prefers-color-scheme
is dark
If supporting prefers-color-scheme
is not a huge overhaul, I'd definitely welcome such a PR. I'm not too keen on adding a button to toggle dark mode (I can't seem to see this lightbulb you mention? Would you mind sharing a screenshot? Is it a browser setting?) but integrating with system preferences seems like a great UI improvement.
Thank you for looking into this!
it's not a huge overhaul, just a slight improvement to the way it already functions.
I can't seem to see this lightbulb you mention
lol yep, the only way i found it was by first looking in the code. it's slightly easier to find on mobile - but it could really use a slight margin so it's easier to find
very top right - and it gets hidden behind the scrollbar
current functionality:
all.sass
proposed functionality:
sound good?
That sounds like a good approach to me, yeah. I wouldn't even be opposed to removing the lightbulb icon altogether, but maybe that's just me, no need to rush that.
I did notice that in dark mode the rss feed and twitter icons become invisible. Is that something you're able to have a look at too, perhaps?
Seems reasonable to me, though hoping rss feed and twitter icons can stay visible. Feel free to open a PR!
cool, working on it!
Are you still working on this?
hi @glozow
would you accept a PR that enables dark mode for users whose operating system indicates prefers-color-scheme:dark ?
i'd be happy to take a look at that