dark mode

[codexnakamoto]

hi @glozow

would you accept a PR that enables dark mode for users whose operating system indicates prefers-color-scheme:dark ?

i'd be happy to take a look at that

[codexnakamoto]

oh wow i just saw the little lightbulb, it's really difficult to spot. i will investigate having it default correctly if prefers-color-scheme is dark

[stickies-v]

If supporting prefers-color-scheme is not a huge overhaul, I'd definitely welcome such a PR. I'm not too keen on adding a button to toggle dark mode (I can't seem to see this lightbulb you mention? Would you mind sharing a screenshot? Is it a browser setting?) but integrating with system preferences seems like a great UI improvement.

Thank you for looking into this!

[codexnakamoto]

it's not a huge overhaul, just a slight improvement to the way it already functions.

I can't seem to see this lightbulb you mention

lol yep, the only way i found it was by first looking in the code. it's slightly easier to find on mobile - but it could really use a slight margin so it's easier to find

very top right - and it gets hidden behind the scrollbar

[codexnakamoto]

current functionality:

• if the lightbulb is clicked, the dark mode hidden checkbox input becomes checked, "dark" is stored in the window.localstorage, and .site-container css variables use the dark values in all.sass
• when the site is loaded, the window.localstorage is checked for the "dark" value, and if found, applies the dark mode

proposed functionality:

• use window.matchmedia and an eventlistener to first establish what the user's prefers-color-scheme is, if found, use that preference
• if prefers-color-scheme is not found, check for the localstorage item and use that
• leave the lightbulb functionality working as is (maybe giving it more margin so it's easier to spot), but with the caveat that prefers-color-scheme will take preference when returning to the site

sound good?

[stickies-v]

That sounds like a good approach to me, yeah. I wouldn't even be opposed to removing the lightbulb icon altogether, but maybe that's just me, no need to rush that.

I did notice that in dark mode the rss feed and twitter icons become invisible. Is that something you're able to have a look at too, perhaps?

[glozow]

Seems reasonable to me, though hoping rss feed and twitter icons can stay visible. Feel free to open a PR!

[codexnakamoto]

cool, working on it!

[glozow]

Are you still working on this?