search

bitcoin-core / bitcoin-maintainer-tools

External repository for Bitcoin Core related maintenance tools
MIT License
137 stars 91 forks source link

check service flags being supported by dns providers #162

Open naiyoma opened 5 months ago

naiyoma commented 5 months ago

Currently, comments for DNS seed filtering are not updated, as discussed here and here. Opening a pull request to update the comments can be noisy. Therefore, I have modified this script to generate all possible combinations of service flags along with their corresponding hexadecimal values and include a function to check if a DNS provider supports a given combination of node services. My proposal is to add a comment referencing this script to ensure all filters are obtained

laanwj commented 5 months ago

This should imo be an optional command-line flag. This script is primarily meant as a quick health check for the DNS seeds. Adding the service bit scanning funcionality could be useful, but i don't think it should be on by default.

naiyoma commented 5 months ago

This should imo be an optional command-line flag. This script is primarily meant as a quick health check for the DNS seeds. Adding the service bit scanning funcionality could be useful, but i don't think it should be on by default.

Nice Suggestion, Ive pushed an update to make --filter-service an optional command