bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
593 stars 464 forks source link

Security advisories for bugs fixed as of Bitcoin Core 0.21.0 #1042

Closed darosior closed 2 weeks ago

darosior commented 2 weeks ago

This publicly discloses 10 security vulnerabilities fixed in Bitcoin Core 0.21.0 or earlier versions.

These writeups result from a common effort to dig up and document past vulnerabilities with achow101 ajtowns fanquake dergoegge and sipa.

darosior commented 2 weeks ago

Thanks everyone for the review. Addressed all comments in the latest push.

sipa commented 2 weeks ago
*  8455:192: ERROR: Invalid first character of tag name '='.
        <h2><a href="/en/2024/06/10/disclose-getdata-cpu/" title="Disclosure of CPU DoS due to malicious P2P message (<= version 0.19.2)">Disclosure of CPU DoS due to malicious P2P message (<= version 0.19.2)</a></h2>
                                                                                                                                                                                               ^ (line 8455)
darosior commented 2 weeks ago
*  8455:192: ERROR: Invalid first character of tag name '='.
        <h2><a href="/en/2024/06/10/disclose-getdata-cpu/" title="Disclosure of CPU DoS due to malicious P2P message (<= version 0.19.2)">Disclosure of CPU DoS due to malicious P2P message (<= version 0.19.2)</a></h2>
                                                                                                                                                                                               ^ (line 8455)

Looks like the CI doesn't like <=, can i just use &le; with Jekyll?

darosior commented 2 weeks ago

I noticed that all of the advisories share the same excerpt " Public disclosure of a DoS vulnerability affecting old versions of Bitcoin Core". Should these perhaps be individualized to actually summarize the content of each advisory?

They are not. It depends on the nature of the vulnerability. For some it's DoS, for other it's RCE or even "censorship". Nonetheless i've now added an excerpt with more details about the content for each post.

*  8455:192: ERROR: Invalid first character of tag name '='.
        <h2><a href="/en/2024/06/10/disclose-getdata-cpu/" title="Disclosure of CPU DoS due to malicious P2P message (<= version 0.19.2)">Disclosure of CPU DoS due to malicious P2P message (<= version 0.19.2)</a></h2>
                                                                                                                                                                                               ^ (line 8455)

I've updated with using &le; instead of using <=. Let's see what the linter says.

achow101 commented 2 weeks ago

Screenshot_20240703_115254

The blog published dates and the disclosure timeline don't match. The dates for the blog section are pulled from the dates in file name.

darosior commented 2 weeks ago

Alright, did one last push to:

darosior commented 2 weeks ago

The blog published dates and the disclosure timeline don't match. The dates for the blog section are pulled from the dates in file name.

Yeah i think this should be fixed now.

achow101 commented 2 weeks ago

ACK 0a549fa737e720abee89431aa05a92e1ffdec4ee

sipa commented 2 weeks ago

ACK 0a549fa737e720abee89431aa05a92e1ffdec4ee

ariard commented 2 weeks ago

@darosior @fanquake @ajtowns @sipa @achow101 @dergoegge

As I suggested on your gist here, I think it would be a good idea to PGP-signed the security advisories to minimize infrastructure compromise risks like the website or github.com being tampered with. Especially, github their 2FA authentication is not great.