Closed Sjors closed 1 year ago
Concept ACK. It makes sense to use a supported version of Ruby for easier local reproducibility.
Concept ACK
I am happy to do what I can to get this moving forward - just ping me for testing.
This is my docker environment for bitcoincore.org dev and testing. Included if others may find it useful to migrate.
https://github.com/bitcoincore-dev/core-org-builder/tree/1644282724-ruby-2-7-alpine3-14
git clone https://github.com/bitcoincore-dev/core-org-builder.git ~/core-org-builder
cd core-org-builder && git checkout 1644282724-ruby-2-7-alpine3-14
git clone https://github.com/bitcoin-core/bitcoincore.org.git ~/bitcoincore.org
cd ~/bitcoincore.org
git remote add sjors https://github.com/Sjors/bitcoincore.org.git
git fetch sjors && git checkout 2021/12/ruby
cd ~/core-org-builder
SITE=~/bitcoincore.org make image
SITE=~/bitcoincore.org make server
I'm planning not to wipe my Buster hosts out until summer, sorry. On the bright side, summer's almost here! 🏖️
I'll wait for that to be merged
Rebased. I can bump the Ruby (patch) version further if we want to use a more modern version of Debian.
Going to merge this just in time for Ruby 2.7
to also go EOL: https://www.ruby-lang.org/en/news/2023/03/30/ruby-2-7-8-released/.
I'll make a PR to bump to 2.7.8 so we can stay on the bleeding edge of the EOL.
Any gems that need bumping?
There's no need for a PR. As as far as I'm aware, that version of ruby won't be available.
Mmm, the release mentions it fixes security issues. Anyway, I can (also) make a PR to the 3.1 or 3.2 series. That involves a bit more testing though.
This requires updating the server to Debian Stable Bullseye, cc TheBlueMatt.
I tested a few pages locally and didn't notice any difference.
I also ran the
htmlproofer
incantation from the README, which I updated to matchMakefile
. Only one minor change was needed to satisfy the updated version.Closes #825