bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
603 stars 470 forks source link

Fix wrong link in translation es #846

Closed katesalazar closed 2 years ago

katesalazar commented 2 years ago

Before this change, "Espanol" > "Bitcoin Core 0.21.2 liberado" links a wrong page, the Japanese release notice.

Should fix issue #844.

laanwj commented 2 years ago

There's some further md files under _posts without permalinks. Do we need to fix all of them?

$ find -name \*.md -exec grep -L permalink {} \;
./es/posts/2021-09-29-release-0.21.2.md
./ja/posts/2021-09-29-release-0.21.2.md
./ja/posts/2021-09-13-release-22.0.md
./ja/posts/2018-09-20-notice.md
./en/posts/2018-12-25-release-0.17.1.md
./en/posts/2021-10-26-release-0.20.2.md
./en/posts/2020-03-27-hidden-service.md
./en/posts/2018-07-29-release-0.16.2.md
./en/posts/2021-05-01-release-0.21.1.md
./en/posts/2020-06-03-release-0.20.0.md
./en/posts/2021-09-29-release-0.21.2.md
./en/posts/2019-08-09-release-0.18.1.md
./en/posts/2019-11-24-release-0.19.0.md
./en/posts/2021-01-14-release-0.21.0.md
./en/posts/2018-09-18-release-0.16.3.md
./en/posts/2020-08-01-release-0.20.1.md
./en/posts/2019-05-02-release-0.18.0.md
./en/posts/2020-03-09-release-0.19.1.md
./en/posts/2021-09-13-release-22.0.md
./en/posts/2018-09-20-notice.md
./en/posts/2018-10-02-release-0.17.0.md
./en/posts/2018-06-15-release-0.16.1.md
./en/posts/2019-11-08-CVE-2017-18350.md

Edit: #854 fixes the Japanese ones, this one fixes the es one, that leaves only the English ones without permalink. No idea if that's a problem there or only for translations.

laanwj commented 2 years ago

ACK 89ce8a7fb7d4ed75a547844f5678c42d21dd5742 anyhow

katesalazar commented 2 years ago

Dunno. Contributors more exposed to Jekyll might know. If those cause any problem, maybe translators will find it.

On Thu, Feb 3, 2022 at 4:00 PM laanwj @.***> wrote:

There's some further md files under _posts without permalinks. Do we need to fix all of them?

$ find -name *.md -exec grep -L permalink {} \; ./es/posts/2021-09-29-release-0.21.2.md ./ja/posts/2021-09-29-release-0.21.2.md ./ja/posts/2021-09-13-release-22.0.md ./ja/posts/2018-09-20-notice.md ./en/posts/2018-12-25-release-0.17.1.md ./en/posts/2021-10-26-release-0.20.2.md ./en/posts/2020-03-27-hidden-service.md ./en/posts/2018-07-29-release-0.16.2.md ./en/posts/2021-05-01-release-0.21.1.md ./en/posts/2020-06-03-release-0.20.0.md ./en/posts/2021-09-29-release-0.21.2.md ./en/posts/2019-08-09-release-0.18.1.md ./en/posts/2019-11-24-release-0.19.0.md ./en/posts/2021-01-14-release-0.21.0.md ./en/posts/2018-09-18-release-0.16.3.md ./en/posts/2020-08-01-release-0.20.1.md ./en/posts/2019-05-02-release-0.18.0.md ./en/posts/2020-03-09-release-0.19.1.md ./en/posts/2021-09-13-release-22.0.md ./en/posts/2018-09-20-notice.md ./en/posts/2018-10-02-release-0.17.0.md ./en/posts/2018-06-15-release-0.16.1.md ./en/posts/2019-11-08-CVE-2017-18350.md

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/bitcoincore.org/pull/846#issuecomment-1029077709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W2SSJAJHIHWXCGKQ2TUZKKCTANCNFSM5MEIPN7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>