bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
603 stars 470 forks source link

Added – Turkish Language v1.0 #853

Open zackha opened 2 years ago

zackha commented 2 years ago

Added – Turkish language option has been added and all pages have been translated into Turkish. ( 26dcc32 )

katesalazar commented 2 years ago

Fix – bitcoin core logo aligned to menu by sick of symmetry (d8074a0)

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

zackha commented 2 years ago

Fix – bitcoin core logo aligned to menu by sick of symmetry (d8074a0)

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

Tested in different widths in responsive browser not found any glitch.

katesalazar commented 2 years ago

...

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

Tested in different widths in responsive browser and found not found any glitch.

Does the pic in div.site-name look good when li#langselect overflows to the second row, under the "About" li? In my browser that's a questionable alignment. It's the only width that I've found worse for your change, though.

zackha commented 2 years ago

...

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

Tested in different widths in responsive browser and found not found any glitch.

Does the pic in div.site-name look good when li#langselect overflows to the second row, under the "About" li? In my browser that's a questionable alignment. It's the only width that I've found worse for your change, though.

I think this looks better when we compare it to the old one. But much better, I can provide a professional touch with fully responsive.

zackha commented 2 years ago

Concept ACK, only the Downloads page is preventing me full ACK. Can't see the untranslated paragraphs displayed in the rendered page. Dunno why they seemed to vanish.

Same problem in Japanese. Now, with a new update, I am making the whole page completely in Turkish, like English and Spanish. Wait for the update.

zackha commented 2 years ago

Concept ACK, only the Downloads page is preventing me full ACK. Can't see the untranslated paragraphs displayed in the rendered page. Dunno why they seemed to vanish.

Download page completely translated in Turkish language (131d121)

zackha commented 2 years ago

~why did you change this?~ (it was previously wrongly at 1)

The original is version 5 in the English document. I converted it from version 5.

katesalazar commented 2 years ago

I still don't understand why remove line:

https://github.com/bitcoin-core/bitcoincore.org/blob/fabd138905877a23d582444e0487b187b2cb2f07/_sass/page.scss#L118

otherwise, ACK 2508debc720a275d

The branch revs are untidied up, but I also think extraordinary and urgency circumstances concur justifying a looser merge requirements for this particular PR

zackha commented 2 years ago

I still don't understand why remove line:

https://github.com/bitcoin-core/bitcoincore.org/blob/fabd138905877a23d582444e0487b187b2cb2f07/_sass/page.scss#L118

otherwise, ACK 2508deb

Because there is no property named decoration in .css Its absence does not constitute a deficiency. Current css renderers suggest a fix to the decoration property. (see. https://www.w3schools.com/cssref/)

katesalazar commented 2 years ago

Great, thanks.

ACK 2508debc720a275d48ef51e987c7e7584d86ed2a

Thanks!

zackha commented 2 years ago

Great, thanks.

ACK 2508deb

Thanks!

You're welcome! I will update the header section next.