Closed maflcko closed 2 years ago
Concept ACK This has no influence on the generated site at all, I guess?
Yeah, it shouldn't. The configs are already None
, so the conditional includes are already disabled. This basically removes dead code.
ci is green
concept ACK, looking forward to review eventually
On Thu, Feb 3, 2022 at 3:32 PM MacroFake @.***> wrote:
Google plus was shut down long ago, so no need to keep any references to it. Also, remove other google settings.
You can view, comment on, or merge this pull request online at:
https://github.com/bitcoin-core/bitcoincore.org/pull/859 Commit Summary
- 8a0062c https://github.com/bitcoin-core/bitcoincore.org/pull/859/commits/8a0062c7741e75e4ee0a4204df87e18e77491c4b remove google plus
File Changes
(5 files https://github.com/bitcoin-core/bitcoincore.org/pull/859/files)
- M _config.yml https://github.com/bitcoin-core/bitcoincore.org/pull/859/files#diff-ecec67b0e1d7e17a83587c6d27b6baaaa133f42482b07bd3685c77f34b62d883 (7)
- M _data/authors.yml https://github.com/bitcoin-core/bitcoincore.org/pull/859/files#diff-fdca1c48b249c38bee14489176341e078b9cfcf168e19ba1c669b92fa7322c49 (6)
- M _includes/author-bio.html https://github.com/bitcoin-core/bitcoincore.org/pull/859/files#diff-81fdade7f6c354430486244df09a7e043189e3b5922cefeca6b6e84f86679bfd (1)
- M _includes/head.html https://github.com/bitcoin-core/bitcoincore.org/pull/859/files#diff-e241bda4e3c3c6dc1c0b00185b61f6ce19b5eb16e294dd955ca9fa6d01befb0e (4)
- M _includes/scripts.html https://github.com/bitcoin-core/bitcoincore.org/pull/859/files#diff-d2aabec5480c331c0119175a7e808edf76bfb7e63bf903691b6c5f4f84eb4476 (12)
Patch Links:
- https://github.com/bitcoin-core/bitcoincore.org/pull/859.patch
- https://github.com/bitcoin-core/bitcoincore.org/pull/859.diff
— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/bitcoincore.org/pull/859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4WYGVDHOSMBPEAFKFV3UZKGYNANCNFSM5NPC7QGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
Concept ACK
approach ACK, untested
rfm? :)
Google plus was shut down long ago, so no need to keep any references to it. Also, remove other google settings.