search

bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
603 stars 470 forks source link

remove google plus #859

Closed maflcko closed 2 years ago

maflcko commented 2 years ago

Google plus was shut down long ago, so no need to keep any references to it. Also, remove other google settings.

laanwj commented 2 years ago

Concept ACK This has no influence on the generated site at all, I guess?

maflcko commented 2 years ago

Yeah, it shouldn't. The configs are already None, so the conditional includes are already disabled. This basically removes dead code.

maflcko commented 2 years ago

ci is green

katesalazar commented 2 years ago

concept ACK, looking forward to review eventually

On Thu, Feb 3, 2022 at 3:32 PM MacroFake @.***> wrote:

Google plus was shut down long ago, so no need to keep any references to it. Also, remove other google settings.

You can view, comment on, or merge this pull request online at:

https://github.com/bitcoin-core/bitcoincore.org/pull/859 Commit Summary

File Changes

(5 files https://github.com/bitcoin-core/bitcoincore.org/pull/859/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/bitcoincore.org/pull/859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4WYGVDHOSMBPEAFKFV3UZKGYNANCNFSM5NPC7QGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

Zero-1729 commented 2 years ago

Concept ACK

katesalazar commented 2 years ago

approach ACK, untested

maflcko commented 2 years ago

rfm? :)