search

bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
603 stars 470 forks source link

Remove redundant and outdated authors sidebar #863

Closed maflcko closed 1 year ago

maflcko commented 2 years ago

This affects the following pages:

All three pages already include the author information in the text, thus the authors sidebar is redundant.

Also, the links might be outdated. For example https://twitter.com/orionwl returns This account doesn’t exist.

Instead of maintaining the sidebar links, remove them as they are redundant.

maflcko commented 2 years ago

For reference, if this gets merged and someone wonders how the site looked like before the changes. An example:

Screen Shot 2022-02-14 at 12 01 26

katesalazar commented 2 years ago

looks like not a bad idea

On Mon, Feb 14, 2022 at 12:00 PM MacroFake @.***> wrote:

This affects the following pages:

All three pages already include the author information in the test, thus the authors sidebar is redundant.

Also, the links might be outdated. For example https://twitter.com/orionwl returns This account doesn’t exist.

Instead of maintaining the sidebar links, remove them as they are redundant.

You can view, comment on, or merge this pull request online at:

https://github.com/bitcoin-core/bitcoincore.org/pull/863 Commit Summary

File Changes

(11 files https://github.com/bitcoin-core/bitcoincore.org/pull/863/files )

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/bitcoincore.org/pull/863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W5FTT7ZUHI4Q2J4CHDU3DOE5ANCNFSM5OLCLIDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

katesalazar commented 2 years ago

Concept ACK

katesalazar commented 2 years ago

Burninate related styles?

https://github.com/bitcoin-core/bitcoincore.org/blob/853d3d56db7f3d4981de0af30c85b078bb032a82/_sass/page.scss#L594-L661

Haven't tested that, dunno if breaks anything.

katesalazar commented 2 years ago

Maybe removing styles breaks the /doc/ layout. But is the author sidebar really informative in the /doc/ layout?

If it just tells "Documentation exported from Bitcoin Core 0.18.0" that's arguably needed there.

Even so, the style can be burninated partially by removing some classes such as bio-photo, I guess.

maflcko commented 2 years ago

Sure, happy to remove more stuff, but I'd prefer to do in small steps to not overexert reviewers

katesalazar commented 2 years ago

Sure, happy to remove more stuff, but I'd prefer to do in small steps to not overexert reviewers

That's good, but removing class bio-photo from scss is part of this PR, more than the next one.

fanquake commented 2 years ago

@harding thoughts?

stickies-v commented 1 year ago

It seems like this PR broke the site layout. On 3b17b95:

image

On the previous head 0f62ce0:

image

maflcko commented 1 year ago

I can't render the website locally, but maybe re-adding an empty <div class="article-author-side"></div> in the four places where I removed it fixes it?

stickies-v commented 1 year ago

but maybe re-adding an empty <div class="article-author-side"></div> in the four places where I removed it fixes it?

I tried that initially but didn't work. Adding &nbsp did the trick, however. Fixed in https://github.com/bitcoin-core/bitcoincore.org/pull/938.