search

bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
593 stars 464 forks source link

RPC Docs: add 23.0.0 #887

Closed andrewtoth closed 1 year ago

andrewtoth commented 1 year ago

Generated using this repo's contrib/doc-gen/generate.go.

Should be fully deterministic, so anyone wanting to review can install 23.0.0 and run the following:

bitcoind --daemon --regtest
cd contrib/doc-gen
go run generate.go

I lightly tested a local preview and didn't see anything broken this release.

Closes https://github.com/bitcoin-core/bitcoincore.org/issues/868.

stickies-v commented 1 year ago

Ran a diff with my locally generated docs, looks like you're missing the rpc/zmq/ subdir, so I think maybe you've configured with --without-zmq? Beyond that, everything matches and I also compared with the changelogs (not every single change, but quite a bit of it) and that all seems to align. So, once rpc/zmq/ is added it's an ACK from me.

andrewtoth commented 1 year ago

@stickies-v good catch thanks. I reran with a binary from bitcoincore.org and it added zmq/getzmqnotifications.html.