search

bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
593 stars 464 forks source link

Adding pt-BR/rss #907

Closed mateusnds closed 1 year ago

mateusnds commented 1 year ago

When translating pages into Portuguese, I get an error saying that there is no rss in Portuguese, so I'm trying to create to follow the page translations

https://github.com/bitcoin-core/bitcoincore.org/pull/905 https://github.com/bitcoin-core/bitcoincore.org/pull/906

Ref:

Use this page to open Pull requests for changes to the Bitcoin Core project website at bitcoincore.org.

bitcoin.org is not connected with or maintained by the Bitcoin Core project contributors. Pull requests for changes to that website should be opened at the bitcoin.org repository.

General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com.

mateusnds commented 1 year ago

:(

what image?

katesalazar commented 1 year ago

what image?

  • image /assets/images/rss-24x24.png does not have an alt attribute (line 169)
  • image /assets/images/rss-24x24.png does not have an alt attribute (line 173)

Maybe it's related to t.rss_feed in: https://github.com/bitcoin-core/bitcoincore.org/blob/dc06536f6d16d0407cb09c6a15787d01dd974a1c/_includes/pages/rss.html#L3 and: https://github.com/bitcoin-core/bitcoincore.org/blob/dc06536f6d16d0407cb09c6a15787d01dd974a1c/_includes/pages/rss.html#L7

note: https://github.com/bitcoin-core/bitcoincore.org/blob/dc06536f6d16d0407cb09c6a15787d01dd974a1c/_data/translations.yml#L11 and: https://github.com/bitcoin-core/bitcoincore.org/blob/dc06536f6d16d0407cb09c6a15787d01dd974a1c/_data/translations.yml#L25 and: https://github.com/bitcoin-core/bitcoincore.org/blob/dc06536f6d16d0407cb09c6a15787d01dd974a1c/_data/translations.yml#L39 and: https://github.com/bitcoin-core/bitcoincore.org/blob/dc06536f6d16d0407cb09c6a15787d01dd974a1c/_data/translations.yml#L53 and: https://github.com/bitcoin-core/bitcoincore.org/blob/dc06536f6d16d0407cb09c6a15787d01dd974a1c/_data/translations.yml#L67

fanquake commented 1 year ago

Please consolidate your changes into a single PR. i.e #905. Rather than opening many different ones.