search

bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
608 stars 474 forks source link

download: add links for arm darwin binaries #920

Closed katesalazar closed 1 year ago

katesalazar commented 1 year ago

This shall close ticket #917.

katesalazar commented 1 year ago
Obsolete (corresponds to rev 9913048bb) Screen Shot 2022-11-15 at 10 56 42 Screen Shot 2022-11-15 at 10 56 24
fanquake commented 1 year ago

Can you provide a new screenshot. Either by updating your previous comment, or deleting it and posting a new one.

katesalazar commented 1 year ago

screenshots using d83eeeb77ceaef62a196e5263177b51ca13e2971 my normal resolution:

Screen Shot 2022-11-15 at 14 28 08

if I maximize:

Screen Shot 2022-11-15 at 14 28 21
hebasto commented 1 year ago

Should this snippet https://github.com/bitcoin-core/bitcoincore.org/blob/d83eeeb77ceaef62a196e5263177b51ca13e2971/_includes/templates/download.html#L321-L324 be also modified to assign the correct file to the Download button when browsing on macOS arm64?

katesalazar commented 1 year ago

ah, the tricky bit

I can push another rev with some swiftly changes, but I don't have the devices to check if it'll be working

On Tue, Nov 15, 2022 at 4:02 PM Hennadii Stepanov @.***> wrote:

Should this snippet https://github.com/bitcoin-core/bitcoincore.org/blob/d83eeeb77ceaef62a196e5263177b51ca13e2971/_includes/templates/download.html#L321-L324 be also modified to assign the correct file to the Download button when browsing on macOS arm64?

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/bitcoincore.org/pull/920#issuecomment-1315436552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W7Z7NWIJFYP3GABUWTWIOQW7ANCNFSM6AAAAAASAEDFJY . You are receiving this because you authored the thread.Message ID: @.***>

fanquake commented 1 year ago

There's no need to bundle that change into this PR. It can be done separately as part of #696.

katesalazar commented 1 year ago

I think a68a7e89b76 should do, but I have not the hardware to check

if does look good write something and I squash asap

fanquake commented 1 year ago

There's no need to bundle that change into this PR. It can be done separately as part of https://github.com/bitcoin-core/bitcoincore.org/issues/696.

Can you just drop the untested changes.

katesalazar commented 1 year ago

There's no need to bundle that change into this PR. It can be done separately as part of #696.

Can you just drop the untested changes.

Yeah, done!