search

bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
593 stars 463 forks source link

Remove laanwj from trusted-keys #952

Closed laanwj closed 1 year ago

laanwj commented 1 year ago

allow-revsig-commits generated using

git log --format="%H %GK" --merges $(cat contrib/verify-commits/trusted-git-root)..master | grep -E " 1E4AED62986CD25D" | cut -c -40 >> contrib/verify-commits/allow-revsig-commits

(thanks ajtowns for the improved script)

laanwj commented 1 year ago

Apparently this doesn't work (see https://github.com/bitcoin/bitcoin/pull/27054#issuecomment-1421213371), changing this to draft for now.

maflcko commented 1 year ago

I think you can just bump the trusted git root, like it was done before?

I never understood the difference, and at least it works in practise.

fanquake commented 1 year ago

I think you can just bump the trusted git root, like it was done before?

@MarcoFalke Want to open a PR to do this?

laanwj commented 1 year ago

I thin the difference is that by keeping the trusted root the same, it's possible to verify all the way down (or at least, further) in some sense. That was always the reason to prefer about everything else to bumping the trusted root. But especially for the website I don't think it's very important.

laanwj commented 1 year ago

I bumped the trusted git root to dc06536f6d16d0407cb09c6a15787d01dd974a1c instead. Pretty sure this is after any of my merges, but please check.

commit dc06536f6d16d0407cb09c6a15787d01dd974a1c
Merge: c78e1e8431a9e767d9ef238896f890716853b05e 62ef4aecf836e5f56b69bde64d66baf95542cc9d
Author: fanquake <fanquake@gmail.com>
Date:   Thu Sep 29 16:27:10 2022 +0100
fanquake commented 1 year ago

but please check.

Looks correct to me. Going to go-ahead and merge this.