bitcoin-core / bitcoincore.org

Bitcoin Core project website
https://bitcoincore.org/
MIT License
593 stars 463 forks source link

update trusted-keys: remove harding, add achow101 and glozow keys #955

Closed glozow closed 1 year ago

glozow commented 1 year ago

Already pinged offline but cc @harding @achow101

FYI removal of harding's key is based on the one added in 3578a84 (I haven't otherwise verified it).

achow101 commented 1 year ago

ACK e71e72c816ad92622d691435887e690d7f55e4df

The keys added match the fingerprints I have for my own key and glozow. The key removed says it belongs to harding, although I did not have it locally before.

As harding does not have the necessary permissions to merge anything, it makes sense to remove his key.

I had asked glozow to add my key when she mentioned she would open a PR to add herself.

pinheadmz commented 1 year ago

concept ACK

The key list matches bitcoin core with the exception of hebasto (D1DBF2C4B96F2DEBF4C16654410108112E7EA81F) is there a reason for that?

glozow commented 1 year ago

is there a reason for that?

hebasto didn't ask me to add his key in this PR, that's all

hebasto commented 1 year ago

is there a reason for that?

hebasto didn't ask me to add his key in this PR, that's all

Confirming :)

RandyMcMillan commented 1 year ago

https://raw.githubusercontent.com/bitcoin/bitcoin/master/contrib/verify-commits/trusted-keys

patch:

diff --git a/contrib/verify-commits/trusted-keys b/contrib/verify-commits/trusted-keys
index c919d84..94daf28 100644
--- a/contrib/verify-commits/trusted-keys
+++ b/contrib/verify-commits/trusted-keys
@@ -1,3 +1,4 @@
 E777299FC265DD04793070EB944D35F9AC3DB76A
+D1DBF2C4B96F2DEBF4C16654410108112E7EA81F
 152812300785C96444D3334D17565732E08E5E41
 6B002C6EA3F91B1B0DF0C9BC8F617F1200A6D25C