bitcoin-core / gitian.sigs

Bitcoin Core release signatures (gitian)
170 stars 224 forks source link

Have Travis verify signatures and check for inconsistencies? #607

Closed Sjors closed 5 years ago

Sjors commented 7 years ago

It's probably overkill (and maybe impossible) to have Travis perform an entire Gitian build, but it might be doable to write a script which compares the assert files between contributors and checks their signatures.

meshcollider commented 7 years ago

I've opened a PR for a comparison script, #614 Would be fairly easy to run gverify too I think but I've left that out for now

laanwj commented 7 years ago

I disagree that this is a good idea, see: https://github.com/bitcoin-core/gitian.sigs/pull/614#issuecomment-343653291

A pre-merge check that would actually be useful for me (that I have to do every time) is one that makes sure that a user is only committing to one of the subdirectories of the various version directory. E.g. a PR coming from MeshCollider commits to */meshcollider/*. I appreciate that the name mapping is non-obvious though.

meshcollider commented 7 years ago

I think it would be easy enough to make sure all files being touched are within directories with the same name (e.g. if I submit sigs in */meshcollider/* and also touch a file in laanwj/ it would fail). The number of gitian builders is probably small enough that a github username -> signing name table could probably be hardcoded in somewhere though right?

maflcko commented 7 years ago

The simplest check would be to assert that each commit only adds files. It should be never required to delete files and very rarely to modify files, so I think that false positive rate is acceptable.

meshcollider commented 6 years ago

@laanwj see https://github.com/bitcoin-core/gitian.sigs/pull/678 for a script which does what you suggest

wumpus commented 6 years ago

I'd suggest asking the correct wumpus.

Sjors commented 6 years ago

Aka @laanwj

meshcollider commented 6 years ago

Heh oops, switching between IRC and github too quickly