Allow BlockClock to scale and maintain 1/3 of the available window real estate

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)

MIT License

107 stars 40 forks source link

Allow BlockClock to scale and maintain 1/3 of the available window real estate #306

Closed jarolrod closed 1 year ago

jarolrod commented 1 year ago

Follow up can allow to customize this scaling in settings.

small window size

master	pr

large window size

master	pr

johnny9 commented 1 year ago

Concept ACK

This is great, glad to see that just increasing the icon size resolves the icon scaling problem. My preference would be 2/3 of the width/height but i'll leave that to the designers to decide on a default.

jarolrod commented 1 year ago

Updated from 87b9f59 to 71a1d99, compare

Changes:

block clock takes up half the space
Network Indicator doesn't scale, stays fixed size

jarolrod commented 1 year ago

Updated from 71a1d99 to d138d1c, compare

Changes: block clock is now 5/12 in size by default, this is halfway between 1/2 and 1/3.

jarolrod commented 1 year ago

Updated from d138d1c to cf6e327, compare

Changes: reverted back to using a scale factor of 1/3. We can fine tune this later

thebagmaster commented 1 year ago

ACK cf6e327 seems to scale fine:

jarolrod commented 1 year ago

Closing this in favor of keeping everything in https://github.com/bitcoin-core/gui-qml/pull/311