search

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
107 stars 40 forks source link

Paint rounded caps at the start and end of the Blockclock dial #309

Open johnny9 opened 1 year ago

johnny9 commented 1 year ago

Windows Intel macOS Apple Silicon macOS ARM64 Android

jarolrod commented 1 year ago

should base on 306

GBKS commented 1 year ago

Rounded edges might work a little more nicely here.

image

I like how in the PR, the top hour indicator dot is covered. Looks cleaner, like the center line of segment starts at midnight/noon, and then the thickness of the line expands from that in all directions (hope that makes any sense, let me know if you want me to visualize it).

Also, is it possible to turn the hour indicator dots into actual circles? They seem like small segments of the block circle right now.

jarolrod commented 1 year ago

@GBKS we will have to patch the line caps within qt, we can do this for right now to get us a tiny bit closer to the designs.

jarolrod commented 1 year ago

Ping @johnny9 any update on the sizing issue here?