Closed jarolrod closed 1 year ago
I have to say, this doesn't feel right. Having to go several screens into settings to adjust the size only having to go back to see what it looks like is just not right. And the big one is so huge on desktop that it looks a bit crazy.
Could we also toggle through the sizes via a simple double-tap on the clock? It does require that the UI can differentiate between single and double-taps, not sure if that's built-on or some custom functionality.
Here's a quick mock-up with some ideas (icons are placeholders). I reframed this as two display modes. One is for active use, the other is called "Showcase". Each has an explainer. For "Showcase", there might be other things we may want to tweak, like hiding the Settings button until you interact with the screen. It could also be cool if the big one renders with more detail, more animations or other unique treatments rather than just being bigger.
Updated from 7626d1f to fd00969, compare
Changes: addressed review feedback
@GBKS I've integrated your suggestion on the "Block Clock display mode" page. But, I've left out the icon until we get an official svg for it (see pictures in PR description). I've also left out the text that you can double tap on the clock; that will be introduced in the followup that implements double tap detection. I've also left out the last sentence in the Showcase
option until that functionality is actually introduced.
The values for default and showtime could use review.
ACK 753d052b4c055559c06023dd7ce781909e3bb51e
Tested and looks good. I slightly tweaked the icons and made them export ready, find them in Figma here.
What do you think of changing "Default" to "Compact"?
Could you also please put the page title in the title bar rather than in the page itself?
And another question about casing. I always use sentence case in design, but I see a good amount of title case in the application. Let's decide on something (obviously I'd go for sentence case). What's your take?
1/2 still feels a tad OP, but let's run with it and see if we want to tweak it after a bit of usage.
@GBKS as shown in the new PR description images, should the Display settings page itself have a title bar?
Yes sir, just "Settings".
cc @GBKS @mouxdesign CI artifacts are built and this can be tested now
Updated from b0f7265 to af0ddf6, rebased over main
This moves "Display" related settings into a new "Display" page. Also sets up QSettings wiring for options.