search

bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
107 stars 40 forks source link

Add looping animation to Estimating state #325

Closed jarolrod closed 1 year ago

jarolrod commented 1 year ago

Implements the following design: https://github.com/BitcoinDesign/Bitcoin-Core-App/issues/48

Windows Intel macOS Apple Silicon macOS ARM64 Android

GBKS commented 1 year ago

Looking good, I think it helps, although it feels just a tad too strong, especially when you also have the peer dots blinking. Could we try animating between Neutral 4 and Neutral 6, please?

It also feels like this animates with a very slow frame rate, like it's lagging a bit (on a very fast MacBook). Do you see the same?

jarolrod commented 1 year ago

Updated from a41be94 to c95771e, compare

Changes: addressed review feedback

@GBKS I don't notice any animation issues

jarolrod commented 1 year ago

updated from c95771e to 1271377

changes: rebased over main

GBKS commented 1 year ago

ACK https://github.com/bitcoin-core/gui-qml/pull/325/commits/1271377ccd80a4484845acabd7c61418fd2247ef