bitcoin-core / gui-qml

Bitcoin GUI (experimental QML-based fork)
MIT License
107 stars 40 forks source link

Remove constraint on continueButton width for mobile #336

Closed jarolrod closed 1 year ago

jarolrod commented 1 year ago

The design file specifies that on mobile, the continueButton should take up the width of the display with a padding of 20px on the left and right. This was correctly implemented in https://github.com/bitcoin-core/gui-qml/pull/171, but then removed in https://github.com/bitcoin-core/gui-qml/pull/190.

Opening for designer feedback.

Windows Intel macOS Apple Silicon macOS ARM64 Android ARM32 Android

jarolrod commented 1 year ago

cc @GBKS @mouxdesign

jarolrod commented 1 year ago

chrisoph on discord: "Yep, so the original layout idea was full-width on mobile and a max-width of 300 on desktop."

jarolrod commented 1 year ago

we don't want this, so closing